[Alerts] ServiceNow SIR Connector#88190
Conversation
a192e05 to
b381eb2
Compare
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
30c2f22 to
800d8a6
Compare
|
Pinging @elastic/uptime (Team:uptime) |
f8ce542 to
d43c63a
Compare
shahzad31
left a comment
There was a problem hiding this comment.
Uptime changes LGTM !!
|
My first impression of the PR changes, that it is something that we should have on the our road map of cowering all the integrations with ServiceNow. This is the particular use case of adding one more table from the ServiceNow to our integrations list. I will to do the next step and open an issue where we should consider a generic support for usage ServiceNow tables. I think that should be a single ServiceNow connector and all tables integrations should be on the params side. Then user will select a table and add the proper fields. Are we able to do this now? |
d90ceef to
764b1d8
Compare
|
@elasticmachine merge upstream |
9860d51 to
96d40a5
Compare
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
...s_ui/public/application/components/builtin_action_types/servicenow/servicenow_sir_params.tsx
Outdated
Show resolved
Hide resolved
| .list() | ||
| /** | ||
| * TODO: Remove when cases connector is available across Kibana. Issue: https://github.com/elastic/kibana/issues/82502. | ||
| * TODO: Need to decide about ServiceNow SIR connector. |
There was a problem hiding this comment.
The alerting team needs to decide if they gonna support ServiceNow SIR connector for alerts.
...actions_ui/public/application/components/builtin_action_types/servicenow/use_get_choices.tsx
Outdated
Show resolved
Hide resolved
stephmilovic
left a comment
There was a problem hiding this comment.
LGTM! Please make those few updates to the react hooks and you're good to go. I tested locally and it works hooray! 🚀
114fa49 to
eabbb41
Compare
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/data_frame_analytics/cloning·ts.machine learning data frame analytics jobs cloning supported by UI form classification job supported by the form opens the existing job in the data frame analytics job wizardStandard OutStack TraceKibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/delete_signals_migrations·ts.detection engine api security and spaces enabled deleting signals migrations rejects the request if the user does not have sufficient privilegesStandard OutStack TraceKibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/delete_signals_migrations·ts.detection engine api security and spaces enabled deleting signals migrations rejects the request if the user does not have sufficient privilegesStandard OutStack TraceMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Release Notes: Adds ServiceNow SIR Alerting connector
This PR implements a connector for ServiveNow SIR.
Technical details:
servicenow-siraction type.servicenow-sirUI.servicenowandservicenow-siruse the same service. Both connectors use the Table API. Only the table name changes. It isincidentfor ServiceNow Incident Management andsn_si_incidentfor ServiceNow SIR. For that reason,createExternalServiceaccepts the table name as an argument.getChoices: (fields: string[]) => Array<{ value: string; label: string; dependent_value: string; element: string; }>subaction was created.configandsecretsscheme. They differ only in theirparams.fieldsUrlto take into account thetasktable.useGetChoiceshook was created to get the choices from the API.fieldsfrom the configuration file of each connector.urgency,priority, andseverityfields of ServiceNow ITSM connector dynamic. They gets their values from thegetChoicessubaction.ServiceNow: Dynamic fields
1.mp4
ServiceNow SIR: Test connector
1.mp4
ServiceNow SIR: Create connector
2.mp4
Meta issue: #82676, https://github.com/elastic/security-team/issues/520
Checklist
Delete any items that are not applicable to this PR.
For maintainers