[APM] Fixes inconsistent labels for throughput & latency#88101
Merged
ogupte merged 5 commits intoelastic:masterfrom Jan 13, 2021
Merged
[APM] Fixes inconsistent labels for throughput & latency#88101ogupte merged 5 commits intoelastic:masterfrom
ogupte merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Jan 12, 2021
formgeist
requested changes
Jan 13, 2021
Contributor
formgeist
left a comment
There was a problem hiding this comment.
Perhaps the description of the issue wasn't clear enough, but we should align everywhere else to the Service overview labels. I've suggested some changes. Beyond this, I found a few issues, perhaps we can fix these in this PR.
- Rename the "Average duration by span type". Somehow we renamed the panel, but never changed the chart, so the title is actually misleading. We should "revert" back to the original title; "Time spent by span type".
- The Latency visualization is set to "Average" but the label in the table says "95th". Not sure when this was introduced, but it's reproducible on
master.
cc @sqren
x-pack/plugins/apm/public/components/app/service_inventory/ServiceList/index.tsx
Outdated
Show resolved
Hide resolved
| 'xpack.apm.transactionsTable.trafficPerMinuteColumnLabel', | ||
| { | ||
| defaultMessage: 'Trans. per minute', | ||
| defaultMessage: 'Traffic (per min)', |
Contributor
There was a problem hiding this comment.
Suggested change
| defaultMessage: 'Traffic (per min)', | |
| defaultMessage: 'Traffic', |
x-pack/plugins/apm/public/components/shared/charts/transaction_charts/index.tsx
Outdated
Show resolved
Hide resolved
Contributor
@formgeist: Good catch! I've fixed it in #88188 |
formgeist
approved these changes
Jan 13, 2021
Contributor
formgeist
left a comment
There was a problem hiding this comment.
Thanks for the changes 👍
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jan 13, 2021
* Closes elastic#87483. Updates several labels to be consistent accross views. * Updates integration tests/snapshots with new term * Changes "traffic" => "throughput" in the labels * addresses feedback from PR * includes tpm unit in Observability overview page and updates test
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jan 13, 2021
* Closes elastic#87483. Updates several labels to be consistent accross views. * Updates integration tests/snapshots with new term * Changes "traffic" => "throughput" in the labels * addresses feedback from PR * includes tpm unit in Observability overview page and updates test
sorenlouv
reviewed
Jan 13, 2021
| }, | ||
| { | ||
| field: 'trafficPerMinute', | ||
| field: 'transactionsPerMinute', |
Contributor
There was a problem hiding this comment.
Shouldn't this have been changed to throughput instead of transactionsPerMinute?
sorenlouv
reviewed
Jan 13, 2021
| serviceName: 'opbeans-python', | ||
| agentName: 'python', | ||
| trafficPerMinute: { | ||
| transactionsPerMinute: { |
sorenlouv
reviewed
Jan 13, 2021
| <TimeseriesChart | ||
| fetchStatus={throughputChartsStatus} | ||
| id="trafficPerMinute" | ||
| id="transactionsPerMinute" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87483. Updates several labels to be consistent across views.