[App Search] Minor const cleanup#87885
Merged
cee-chen merged 3 commits intoelastic:masterfrom Jan 11, 2021
Merged
Conversation
Contributor
Author
|
NOTE TO SELF: this will have a merge conflict with #87752 (in |
72ad74b to
1270762
Compare
… folders - might as well get it set up early + prevents us from forgetting to clean this up later
1270762 to
ef261bf
Compare
JasonStoltz
approved these changes
Jan 11, 2021
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
cee-chen
pushed a commit
that referenced
this pull request
Jan 12, 2021
* DRY out repeated DOCUMENTS_TITLE * Move temporary title const's in engine folder to their own respective folders - might as well get it set up early + prevents us from forgetting to clean this up later * Update engine nav & engine router files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minor cleanup PR. We have some temporary i18n constants hanging out in
engine/constants.tsthat I've opted to preemptively create folders+constants files for ahead of time. This should make new component folder changes a little less of a headache in the future, + it's less likely we'll forget to update/clean upengine/constants.tsas we go.Checklist