[Transform] Show destination index mapping warning for the latest transform#87858
Merged
darnautov merged 4 commits intoelastic:masterfrom Jan 12, 2021
Merged
[Transform] Show destination index mapping warning for the latest transform#87858darnautov merged 4 commits intoelastic:masterfrom
darnautov merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
lcawl
reviewed
Jan 11, 2021
| <p> | ||
| <FormattedMessage | ||
| id="xpack.transform.stepDetailsForm.destinationIndexWarning" | ||
| defaultMessage="Note that dynamic mappings based on the source fields will be used if the destination index does not exist. If alternate mappings are required, use the {docsLink} prior to starting the transform. If the transform fails, please check the messages tab for the transform on the Stack Management page for errors." |
Member
There was a problem hiding this comment.
Suggested change
| defaultMessage="Note that dynamic mappings based on the source fields will be used if the destination index does not exist. If alternate mappings are required, use the {docsLink} prior to starting the transform. If the transform fails, please check the messages tab for the transform on the Stack Management page for errors." | |
| defaultMessage="Before you start the transform, use index templates or the {docsLink} to ensure the mappings for your destination index match the source index. If the transform fails, check the messages tab on the Stack Management page for errors." |
Contributor
|
Technically the callout seems to be horizontally aligned with the Here's an alternative version, it will consume more vertical space though, but it's still in line with what the EUI docs suggest (https://elastic.github.io/eui/#/forms/form-validation), what do you think?
|
Contributor
Author
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jan 12, 2021
…nsform (elastic#87858) * [Transform] show callout for the latest transform * [Transform] fix flex styles * [Transform] change to vertical layout, update warning message * [Transform] fix messages
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jan 12, 2021
…nsform (elastic#87858) * [Transform] show callout for the latest transform * [Transform] fix flex styles * [Transform] change to vertical layout, update warning message * [Transform] fix messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With a recently revealed elasticsearch bug with the dynamic mappings, we need to show a warning callout in the UI.