Skip to content

[APM] Cleanup: Remove isValidCoordinateValue and getResponseTimeTooltipFormatter#87836

Merged
sorenlouv merged 1 commit intoelastic:masterfrom
sorenlouv:minor-cleanup
Jan 11, 2021
Merged

[APM] Cleanup: Remove isValidCoordinateValue and getResponseTimeTooltipFormatter#87836
sorenlouv merged 1 commit intoelastic:masterfrom
sorenlouv:minor-cleanup

Conversation

@sorenlouv
Copy link
Copy Markdown
Contributor

  • Remove isValidCoordinateValue and getResponseTimeTooltipFormatter
  • Add fallback value to asDecimal and asInteger to align with other formatters

@sorenlouv sorenlouv requested a review from a team January 11, 2021 13:59
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jan 11, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1735 1734 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB -909.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.12.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants