Fix flaky test for legacy authorization#87642
Merged
mikecote merged 6 commits intoelastic:masterfrom Jan 15, 2021
Merged
Conversation
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
gmmorris
approved these changes
Jan 15, 2021
Contributor
gmmorris
left a comment
There was a problem hiding this comment.
LGTM, does seem like we had some unnecessary leftover there.
Thanks for cleaning that up.
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jan 15, 2021
* Unskip test * Increase attempts to 2 for retryIfConflicts * Cleanup authorization for updateApiKey
mikecote
added a commit
that referenced
this pull request
Jan 15, 2021
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jan 26, 2021
* Unskip test * Increase attempts to 2 for retryIfConflicts * Cleanup authorization for updateApiKey
mikecote
added a commit
that referenced
this pull request
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #87010.
Resolves #87098.
Resolves #86952.
The flaky test #87010 uncovered a single occurrence of two things:
retryIfConflictsattemptsupdateApiKeywhen it should have been unauthorizedIn this PR, I've increased the
retryIfConflictsattempts from1to2for the special case that does happen. For the authorization allowing theupdateApiKeycall, I couldn't reproduce this, and it could have been fixed already with a PR between then and now. Due to not being able to reproduce and discover the underlying cause, I cleaned up some code that no longer seemed necessary in theupdateApiKeyfunction. I hope this may help or resolve the flaky scenario.Flaky test runs: