[Security Solution][Detections] Follow up cleanup after two bugfixes#87516
Merged
banderror merged 2 commits intoelastic:masterfrom Jan 6, 2021
Merged
[Security Solution][Detections] Follow up cleanup after two bugfixes#87516banderror merged 2 commits intoelastic:masterfrom
banderror merged 2 commits intoelastic:masterfrom
Conversation
banderror
commented
Jan 6, 2021
Comment on lines
+19
to
+36
| export const ExternalLink: FC<ExternalLinkProps> = ({ url, children, ariaLabel }) => { | ||
| if (!children) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <EuiLink href={url} aria-label={ariaLabel} external target="_blank" rel="noopener"> | ||
| {text} | ||
| </EuiLink> | ||
| <EuiToolTip content={url} position="top" data-test-subj="externalLinkTooltip"> | ||
| <EuiLink | ||
| href={url} | ||
| aria-label={ariaLabel} | ||
| external | ||
| target="_blank" | ||
| rel="noopener" | ||
| data-test-subj="externalLink" | ||
| > | ||
| {children} | ||
| </EuiLink> | ||
| </EuiToolTip> |
Contributor
Author
There was a problem hiding this comment.
This guy needs unification with ExternalLink component from x-pack/plugins/security_solution/public/common/components/links/index.tsx. I'll create a ticket for that and address separately targeting 7.12+, because this change can touch too many things in the UI.
dplumlee
approved these changes
Jan 6, 2021
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
To update your PR or re-run it, just comment with: |
banderror
added a commit
to banderror/kibana
that referenced
this pull request
Jan 6, 2021
…lastic#87516) ## Summary This is a follow-up PR addressing some of the comments in: - elastic#86908 - elastic#87004
banderror
added a commit
to banderror/kibana
that referenced
this pull request
Jan 6, 2021
…lastic#87516) ## Summary This is a follow-up PR addressing some of the comments in: - elastic#86908 - elastic#87004
banderror
added a commit
that referenced
this pull request
Jan 7, 2021
banderror
added a commit
that referenced
this pull request
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up PR addressing some of the comments in:
Checklist
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)[ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)[ ] This was checked for cross-browser compatibilityFor maintainers