[DOCS] improving production documentation for task manager and alerting#87484
Merged
bmcconaghy merged 3 commits intoelastic:masterfrom Jan 6, 2021
Merged
Conversation
gmmorris
reviewed
Jan 6, 2021
gmmorris
reviewed
Jan 6, 2021
gmmorris
reviewed
Jan 6, 2021
Comment on lines
+22
to
+24
| | `xpack.task_manager.max_poll_inactivity_cycles` | ||
| | How many poll interval cycles can work take before it's timed out. Defaults to 10. | ||
|
|
Contributor
There was a problem hiding this comment.
I'm not sure we should include this.
I don't expect customers to change this - if they go too low it might restart TM prematurely and we've yet to see a deployment where the default wasn't sufficient
gmmorris
approved these changes
Jan 6, 2021
Contributor
gmmorris
left a comment
There was a problem hiding this comment.
Other than the comments I made this all makes sense 👍
LGTM
This was referenced Jan 6, 2021
Merged
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
Jan 6, 2021
…ng (elastic#87484) * improving production documentation for task manager and alerting * calling it Kibana Task Manager to be more explicit * addressing PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78431
Adding documentation for settings for task manager, calling out specifically that the task manager index needs to have a replica count of at least 1 for production, and renaming a section to make its purpose clearer.