[Uptime] Waterfall Chart - enable timings for local files by leveraging total time#87424
Conversation
|
Pinging @elastic/uptime (Team:uptime) |
x-pack/plugins/uptime/public/components/monitor/synthetics/step_detail/waterfall/types.ts
Outdated
Show resolved
Hide resolved
71b24c6 to
117ef60
Compare
117ef60 to
67fc179
Compare
| acc.push({ | ||
| x: index, | ||
| y0: currentOffset, | ||
| y: currentOffset + item.timings.total, |
There was a problem hiding this comment.
so total will always be there?
There was a problem hiding this comment.
Vignesh believes that it will be available for static files.
I've added additional logic to account for scenarios in which total is unavailable, as well as scenarios in which the entire timings object is unavailable.
I noticed that this is the case for when the connection is refused. All items, including the total, are listed as -1. With my new logic, this is what the behavior would be. There is no hover state.
This is when there is nothing up and running on localhost:8000
There was a problem hiding this comment.
Correction: I'm able to remove the tooltip but not the background hover state, which seems to come bundled with passing a custom tooltip to the BarSeries from Elastic Charts. I've yet to discover a way to either use a custom tooltip or specify the tooltip as none on a per datum basis. I can continue the conversation in the elastic charts chat on Monday.
There was a problem hiding this comment.
Total would always be there for all requests. We need to just use them as fallback when we don't have timings for other parts of the request.
|
@elasticmachine merge upstream |
…les' of https://github.com/dominiqueclarke/kibana into fix/86331-uptime-waterfall-enable-timings-for-static-files
|
@elasticmachine merge upstream |
…les' of https://github.com/dominiqueclarke/kibana into fix/86331-uptime-waterfall-enable-timings-for-static-files
shahzad31
left a comment
There was a problem hiding this comment.
LGTM, Great work and improvement !!
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…ng total time (elastic#87424) * uptime waterfall enable timings for static files by leveraging total time * update cases for when their is no waterfall timing available * add showTooltip propertier to WaterfallDataSeriesConfigProperties * remove content downloading from the legend * add mime type to content downloading label Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…ng total time (elastic#87424) * uptime waterfall enable timings for static files by leveraging total time * update cases for when their is no waterfall timing available * add showTooltip propertier to WaterfallDataSeriesConfigProperties * remove content downloading from the legend * add mime type to content downloading label Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…ng total time (#87424) (#87930) * uptime waterfall enable timings for static files by leveraging total time * update cases for when their is no waterfall timing available * add showTooltip propertier to WaterfallDataSeriesConfigProperties * remove content downloading from the legend * add mime type to content downloading label Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…ng total time (#87424) (#87931) * uptime waterfall enable timings for static files by leveraging total time * update cases for when their is no waterfall timing available * add showTooltip propertier to WaterfallDataSeriesConfigProperties * remove content downloading from the legend * add mime type to content downloading label Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fixes #86331
Summary
This PR creates an entry for a resource in the waterfall chart, even when individual timing values are unavailable, as is the case with local files. We first loop through checking the specific timings. If an entry is not found for specific timing values, in the case where all the specific named timings equal
-1, then we move on and use the total time.Test cases