[Enterprise Search] Add a helper for clearFlashMessages#87383
Merged
scottybollinger merged 1 commit intoelastic:masterfrom Jan 5, 2021
Merged
Conversation
This PR adds a convenience function for clearing flash messages to align with others.
cee-chen
approved these changes
Jan 5, 2021
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
To update your PR or re-run it, just comment with: |
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Jan 5, 2021
This PR adds a convenience function for clearing flash messages to align with others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a convenience function for clearing flash messages to align with others.
Summary
In Workplace Search there were several places where we were only importing FlashMessagesLogic to call this method and it would be cleaner to have this helper along with the others.
Checklist