Skip to content

Telemetry plugins esclient migration#87356

Merged
TinaHeiligers merged 3 commits intoelastic:masterfrom
TinaHeiligers:telemetry-plugins-esclient-migration
Jan 6, 2021
Merged

Telemetry plugins esclient migration#87356
TinaHeiligers merged 3 commits intoelastic:masterfrom
TinaHeiligers:telemetry-plugins-esclient-migration

Conversation

@TinaHeiligers
Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers commented Jan 5, 2021 •
edited
Loading

Summary

Migrates the telemetry-related plugins' elasticsearch client to the new client.
Removes support for the legacy elasticsearch client from the usage_collector's fetch context.
Resolves #83124

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Dev docs

This PR removes support for the legacy elasticsearch client from the usage collector's fetch context

@TinaHeiligers TinaHeiligers added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Feature:Telemetry release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 v7.12.0 labels Jan 5, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 5, 2021

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47252 48012 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers mentioned this pull request Jan 5, 2021
Closed
3 tasks
@TinaHeiligers TinaHeiligers marked this pull request as ready for review January 5, 2021 21:26
@TinaHeiligers TinaHeiligers requested review from a team as code owners January 5, 2021 21:26
@TinaHeiligers TinaHeiligers requested a review from a team January 5, 2021 21:26
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 5, 2021

Pinging @elastic/kibana-core (Team:Core)

mattkime
mattkime approved these changes Jan 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App Services changes lgtm

Bamieh
Bamieh approved these changes Jan 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TinaHeiligers TinaHeiligers merged commit 70c7087 into elastic:master Jan 6, 2021
@TinaHeiligers TinaHeiligers deleted the telemetry-plugins-esclient-migration branch January 6, 2021 19:57
@TinaHeiligers TinaHeiligers mentioned this pull request Jan 6, 2021
Merged
TinaHeiligers added a commit that referenced this pull request Jan 6, 2021
@TinaHeiligers
[7.x] Telemetry plugins esclient migration (#87356) (#87570)
3e172d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkime mattkime mattkime approved these changes

@Bamieh Bamieh Bamieh approved these changes

+1 more reviewer

@chrisronline chrisronline chrisronline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Telemetry release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Telemetry][Usage Collection] Finish migration to the new elasticsearch client

6 participants

@TinaHeiligers @kibanamachine @elasticmachine @chrisronline @mattkime @Bamieh