Skip to content

chore(NA): move es_ui_shared tests out of __tests__ folder#87352

Merged
mistic merged 1 commit intoelastic:masterfrom
mistic:move-es_ui_shared-from-tests-folder
Jan 6, 2021
Merged

chore(NA): move es_ui_shared tests out of __tests__ folder#87352
mistic merged 1 commit intoelastic:masterfrom
mistic:move-es_ui_shared-from-tests-folder

Conversation

@mistic
Copy link
Copy Markdown
Contributor

@mistic mistic commented Jan 5, 2021

It moves the second item of #85513 as it moves es_ui_shared out of tests folder into our common setup for tests run with jest.

@mistic mistic added chore Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.11.1 labels Jan 5, 2021
@mistic mistic requested a review from tylersmalley January 5, 2021 17:37
@mistic mistic requested a review from a team as a code owner January 5, 2021 17:37
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 5, 2021

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic changed the title chore(NA): move es_ui_shared out of __tests__ folder chore(NA): move es_ui_shared tests out of __tests__ folder Jan 5, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 5, 2021

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47252 48014 +762
oss 27713 27715 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth
alisonelizabeth approved these changes Jan 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@mistic mistic merged commit 31c667a into elastic:master Jan 6, 2021
@mistic
Copy link
Copy Markdown
Contributor Author

mistic commented Jan 6, 2021 •
edited
Loading

7.x/7.12: aa687b6
7.11/7.11.1: a2a4a75

@mistic mistic mentioned this pull request Jan 6, 2021
Merged
mistic added a commit to mistic/kibana that referenced this pull request Jan 6, 2021
@mistic
chore(NA): move es_ui_shared out of __tests__ folder (elastic#87352)
68e22d7
@mistic mistic mentioned this pull request Jan 6, 2021
Merged
mistic added a commit to mistic/kibana that referenced this pull request Jan 6, 2021
@mistic
chore(NA): move es_ui_shared out of __tests__ folder (elastic#87352)
ab9daf3
mistic added a commit that referenced this pull request Jan 6, 2021
@mistic
chore(NA): move es_ui_shared out of __tests__ folder (#87352) (#87418)
a2a4a75
mistic added a commit that referenced this pull request Jan 6, 2021
@mistic @kibanamachine
chore(NA): move es_ui_shared out of __tests__ folder (#87352) (#87417)
aa687b6 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees

No one assigned

Labels

chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.11.1 v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mistic @elasticmachine @kibanamachine @tylersmalley @alisonelizabeth