[Security Solution][Detections] Re-enable skipped integration test#87254
Merged
rylnd merged 4 commits intoelastic:masterfrom Jan 5, 2021
Merged
[Security Solution][Detections] Re-enable skipped integration test#87254rylnd merged 4 commits intoelastic:masterfrom
rylnd merged 4 commits intoelastic:masterfrom
Conversation
This failure may still be present/intermittent, but it passes reliably locally; trying again on CI to check status.
This should fail on the latest snapshot
Contributor
Author
|
After a little more investigation, these were still passing locally on master, which I believed was due to the lack of a new snapshot. These tests failed consistently locally on both the 7.11 and 7.x branches, which both have newer snapshots. Indeed, once a new 8.0.0 snapshot became available today, master failed similarly. This failure was due to the behavior change in this commit, which was not present in the master snapshot until today. This change was discussed and so the integration failure was expected and merely needs to be updated to reflect the new filtering logic in EQL. |
We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Jan 5, 2021
…lastic#87254) * Re-enable test skipped due to temporary failure This failure may still be present/intermittent, but it passes reliably locally; trying again on CI to check status. * Triggering build This should fail on the latest snapshot * Update EQL integration tests to reflect new default pipe We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Jan 5, 2021
…lastic#87254) * Re-enable test skipped due to temporary failure This failure may still be present/intermittent, but it passes reliably locally; trying again on CI to check status. * Triggering build This should fail on the latest snapshot * Update EQL integration tests to reflect new default pipe We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rylnd
added a commit
that referenced
this pull request
Jan 6, 2021
…87254) (#87397) * Re-enable test skipped due to temporary failure This failure may still be present/intermittent, but it passes reliably locally; trying again on CI to check status. * Triggering build This should fail on the latest snapshot * Update EQL integration tests to reflect new default pipe We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rylnd
added a commit
that referenced
this pull request
Jan 6, 2021
…87254) (#87396) * Re-enable test skipped due to temporary failure This failure may still be present/intermittent, but it passes reliably locally; trying again on CI to check status. * Triggering build This should fail on the latest snapshot * Update EQL integration tests to reflect new default pipe We were previously using what is effectively `results | head` to retrieve the desired amount of results. The default behavior was changed in elastic/elasticsearch#66387, which caused these tests to fail as different results were returned over such a large dataset. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #86709. This failure was due to this change in EQL. This was an expected change, and the solution here is simply to update the integration tests to reflect the new behavior.
For maintainers