[Lens] Migrate data table visualization to data grid#87152
Closed
flash1293 wants to merge 5 commits intoelastic:masterfrom
Closed
[Lens] Migrate data table visualization to data grid#87152flash1293 wants to merge 5 commits intoelastic:masterfrom
flash1293 wants to merge 5 commits intoelastic:masterfrom
Conversation
dej611
reviewed
Jan 11, 2021
Contributor
dej611
left a comment
There was a problem hiding this comment.
Reviewed the code, while the number of lines increased the table component itself seems much easier to organise now!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72504
This PR migrates the Lens data table visualization to data grid.
To do:
Considerations
On dashboards we can't persist state at the moment. However it's possible to resize columns - on navigating away from the dashboard, this state is lost.
[skip ci]