-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Lens] Replace basic table with EuiDataGrid #72504
Copy link
Copy link
Closed
Labels
Feature:LensTeam:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//technical debtImprovement of the software architecture and operational architectureImprovement of the software architecture and operational architecture
Metadata
Metadata
Assignees
Labels
Feature:LensTeam:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//technical debtImprovement of the software architecture and operational architectureImprovement of the software architecture and operational architecture
Type
Fields
Give feedbackNo fields configured for issues without a type.
Edit: Discussion concluded and this is now a recommended improvement that is not really a new feature, but tech debt we should tackle
The current Lens table implementation is very simple and supports no interactivity or custom styling. There are three elements to the discussion of replacing the Lens table with a more powerful table:
Unless there is a strong reason to use the data grid in one of these categories, Lens should not switch.
Product requirements that might need to be supported
Based on the table features for Lens:
The main difference is therefore support for changing column width, reordering columns, and subtotal rows.
Technical requirements
The EuiDataGrid must be performant and stable before we switch.
Consistency across Kibana
Currently, the EuiBasicTable is used in every table visualization that can be embedded in a dashboard, except for the upcoming Discover implementation. If we make a change only in Lens, will this introduce inconsistency?
Conclusion
Based on this analysis of the requirements for Lens tables, I do not think that the benefits outweigh the costs of switching.
cc @elastic/eui-design