[Security Solution] JSON view for data is not displayed properly#87008
Merged
patrykkopycinski merged 9 commits intoelastic:masterfrom Jan 5, 2021
Merged
[Security Solution] JSON view for data is not displayed properly#87008patrykkopycinski merged 9 commits intoelastic:masterfrom
patrykkopycinski merged 9 commits intoelastic:masterfrom
Conversation
Contributor
|
|
Contributor
Author
|
@elasticmachine merge upstream |
| height: 100%; | ||
| `; | ||
| const TabListHeight = 48; | ||
| const StyledEuiFlexItem = styled(EuiFlexItem)<{ $tabListHeight?: number; $messageHeight?: number }>` |
Contributor
There was a problem hiding this comment.
can we try to achieve the same just with the css? using ref can have impact on the performance
cnasikas
approved these changes
Jan 5, 2021
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Jan 5, 2021
…stic#87008) # Conflicts: # x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Jan 5, 2021
…stic#87008) # Conflicts: # x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx
patrykkopycinski
added a commit
that referenced
this pull request
Jan 5, 2021
) (#87330) # Conflicts: # x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
patrykkopycinski
added a commit
that referenced
this pull request
Jan 5, 2021
#87008) (#87329) * [Security Solution] JSON view for data is not displayed properly (#87008) # Conflicts: # x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx * Update event_details.test.tsx Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The content of Json viewer in Alert details / Event details is chopped because of styling problem.
More Description and steps to reproduce:
#86098