Skip to content

[Time to Visualize] Align Lens & Visualize Breadcrumbs#86941

Merged
ThomThomson merged 6 commits intoelastic:masterfrom
ThomThomson:feature/alignLensAndVisBreadcrumbs
Jan 5, 2021
Merged

[Time to Visualize] Align Lens & Visualize Breadcrumbs#86941
ThomThomson merged 6 commits intoelastic:masterfrom
ThomThomson:feature/alignLensAndVisBreadcrumbs

Conversation

@ThomThomson
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson commented Dec 24, 2020

Summary

Fixes #81250 by aligning the behaviour and appearance of the breadcrumbs between Visualize and Lens

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// Feature:Vis Editor Visualization editor issues v8.0.0 Project:TimeToVisualize v7.12.0 labels Dec 24, 2020
@ThomThomson
Copy link
Copy Markdown
Contributor Author

ThomThomson commented Jan 4, 2021

@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review January 4, 2021 18:13
@ThomThomson ThomThomson requested a review from a team January 4, 2021 18:13
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 4, 2021

Pinging @elastic/kibana-presentation (Team:Presentation)

@stratoula
Copy link
Copy Markdown
Contributor

stratoula commented Jan 5, 2021

@elasticmachine merge upstream

stratoula
stratoula reviewed Jan 5, 2021
View reviewed changes
src/plugins/visualize/public/application/utils/breadcrumbs.ts
},
};

const defaultEditText = i18n.translate('visualize.editor.defaultEditBreadcrumbText', {
Copy link
Copy Markdown
Contributor

@stratoula stratoula Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be deleted from the translations files in order to be translated again

Copy link
Copy Markdown
Contributor Author

@ThomThomson ThomThomson Jan 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dej611 and I had a discussion about this a couple months ago, and I was under the impression that only unused translations should be removed, and changed translations were easier for the translators if the old translation is kept in place. I could be wrong though!

stratoula
stratoula approved these changes Jan 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I have tested it locally and it seems that the breadcrumbs work the same now for Lens and Visualize. I have tested both saved visualizations and embedded by value visualizations and the breadcrumbs work as they should 👏

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 5, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualize 130.7KB 131.6KB +886.0B

Distributable file count

id before after diff
default 47252 48012 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualize 42.3KB 42.3KB +64.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 38a7e2b into elastic:master Jan 5, 2021
@ThomThomson ThomThomson mentioned this pull request Jan 5, 2021
Merged
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Jan 5, 2021
@ThomThomson
[Time to Visualize] Align Lens & Visualize Breadcrumbs (elastic#86941)
cbd9b15 
* Aligned Lens & Visualize Breadcrumbs
ThomThomson added a commit that referenced this pull request Jan 6, 2021
@ThomThomson
[Time to Visualize] Align Lens & Visualize Breadcrumbs (#86941) (#87395)
530095e 
* Aligned Lens & Visualize Breadcrumbs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

Feature:Vis Editor Visualization editor issues Project:TimeToVisualize release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Time To Visualize] Unify Breadcrumbs Between Lens & Visualize

4 participants

@ThomThomson @elasticmachine @stratoula @kibanamachine