Skip to content

Enable new chart library setting#86538

Merged
nickofthyme merged 5 commits intoelastic:masterfrom
nickofthyme:enable-new-chart-library
Dec 22, 2020
Merged

Enable new chart library setting#86538
nickofthyme merged 5 commits intoelastic:masterfrom
nickofthyme:enable-new-chart-library

Conversation

@nickofthyme
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme commented Dec 18, 2020 •
edited
Loading

Summary

Enables new chart library by setting visualization:visualize:legacyChartsLibrary advanced setting to false in master.

Waiting to merge #86529 before opening for review.

@nickofthyme nickofthyme added the Feature:XYAxis XY-Axis charts (bar, area, line) label Dec 18, 2020
@nickofthyme nickofthyme mentioned this pull request Dec 18, 2020
Merged
2 tasks
@nickofthyme nickofthyme force-pushed the enable-new-chart-library branch from 7c85fcd to 9c69cad Compare December 18, 2020 21:42
@nickofthyme
Copy link
Copy Markdown
Contributor Author

nickofthyme commented Dec 19, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 19, 2020

merge conflict between base and head

@nickofthyme nickofthyme force-pushed the enable-new-chart-library branch from 9c69cad to 5ea2af4 Compare December 19, 2020 04:03
@nickofthyme nickofthyme marked this pull request as ready for review December 19, 2020 04:03
@nickofthyme nickofthyme requested a review from a team December 19, 2020 04:03
@nickofthyme nickofthyme added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Dec 19, 2020
@nickofthyme
Copy link
Copy Markdown
Contributor Author

nickofthyme commented Dec 21, 2020

@elasticmachine merge upstream

stratoula
stratoula approved these changes Dec 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested locally in chrome. Works as expected 🙂

@nickofthyme nickofthyme added backport:skip This PR does not require backporting v8.0.0 and removed v8.0.0 labels Dec 22, 2020
@nickofthyme nickofthyme merged commit 3aeb344 into elastic:master Dec 22, 2020
@nickofthyme nickofthyme changed the title Enable new chart library Enable new chart library setting Dec 22, 2020
@nickofthyme nickofthyme deleted the enable-new-chart-library branch December 22, 2020 16:06
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 22, 2020

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47143 47903 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeVislib 46.7KB 46.7KB +1.0B
visTypeXy 67.6KB 67.6KB +1.0B
total +2.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme mentioned this pull request Feb 17, 2021
Merged
nickofthyme added a commit that referenced this pull request Feb 17, 2021
@nickofthyme
Enable new chart library setting (#86538) (#91705)
a4a74c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:XYAxis XY-Axis charts (bar, area, line) release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickofthyme @kibanamachine @stratoula