Skip to content

[ML] Fix error callout for Anomaly detection jobs using runtime_mappings#86407

Merged
qn895 merged 7 commits intoelastic:masterfrom
qn895:ml-disable-scripted-fields
Dec 22, 2020
Merged

[ML] Fix error callout for Anomaly detection jobs using runtime_mappings#86407
qn895 merged 7 commits intoelastic:masterfrom
qn895:ml-disable-scripted-fields

Conversation

@qn895
Copy link
Copy Markdown
Member

@qn895 qn895 commented Dec 18, 2020 •
edited by peteharverson
Loading

Summary

This PR fixes issues with the Anomaly explorer chart showing empty when the job uses a runtime field when model plot is not enabled. Changes include:

  • Fix Anomaly chart so it shows up correctly when model plot is enabled

Screen Shot 2020-12-17 at 17 51 37

  • Show a warning call out in Anomaly chart when model plot is off

Screen Shot 2020-12-17 at 17 51 09

  • Completely disable the Single Metric Viewer with message

Screen Shot 2020-12-17 at 17 49 38

  • Fix issue with Single Metric Viewer redirecting to another job without any warning/toast message

Screen Shot 2020-12-17 at 17 50 17

  • Adds spacer

Checklist

@qn895 qn895 added the :ml label Dec 18, 2020
@qn895 qn895 self-assigned this Dec 18, 2020
@qn895 qn895 added bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Dec 18, 2020
@qn895 qn895 marked this pull request as ready for review December 18, 2020 00:06
@qn895 qn895 requested a review from a team as a code owner December 18, 2020 00:06
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 18, 2020

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Dec 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

jgowdyelastic
jgowdyelastic reviewed Dec 21, 2020
View reviewed changes
x-pack/plugins/ml/common/util/job_utils.ts Outdated
}

// We also cannot plot the source data if they datafeed uses any field defined by runtime_mappings
const runtimeMappings =
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic Dec 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of this code is duplicated, it might be worth creating a hasRuntimeMappings function which returns a boolean which is used in both of these functions?

Copy link
Copy Markdown
Member Author

@qn895 qn895 Dec 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here 0175531

jgowdyelastic
jgowdyelastic approved these changes Dec 21, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Copy Markdown
Member Author

qn895 commented Dec 22, 2020

@elasticmachine merge upstream

@qn895 qn895 closed this Dec 22, 2020
@qn895 qn895 deleted the ml-disable-scripted-fields branch December 22, 2020 16:01
@qn895 qn895 restored the ml-disable-scripted-fields branch December 22, 2020 16:08
@qn895 qn895 reopened this Dec 22, 2020
@peteharverson peteharverson mentioned this pull request Dec 22, 2020
Open
61 tasks
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 22, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 7.0MB 7.0MB +792.0B

Distributable file count

id before after diff
default 47144 47904 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895 qn895 merged commit 61eb83b into elastic:master Dec 22, 2020
@qn895 qn895 deleted the ml-disable-scripted-fields branch December 22, 2020 18:22
qn895 added a commit to qn895/kibana that referenced this pull request Dec 22, 2020
@qn895 @kibanamachine
[ML] Fix error callout for Anomaly detection jobs using runtime_mappi…
c107223 
…ngs (elastic#86407)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@qn895 qn895 mentioned this pull request Dec 22, 2020
Merged
qn895 added a commit to qn895/kibana that referenced this pull request Dec 22, 2020
@qn895 @kibanamachine
[ML] Fix error callout for Anomaly detection jobs using runtime_mappi…
12a19b7 
…ngs (elastic#86407)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@qn895 qn895 mentioned this pull request Dec 22, 2020
Merged
qn895 added a commit that referenced this pull request Dec 22, 2020
@qn895 @kibanamachine
[7.x] [ML] Fix error callout for Anomaly detection jobs using runtime…
4a1c3c6 
…_mappings (#86407) (#86816)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
qn895 added a commit that referenced this pull request Dec 23, 2020
@qn895 @kibanamachine
[7.11] [ML] Fix error callout for Anomaly detection jobs using runtim…
9bb11c6 
…e_mappings (#86407) (#86817)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@qn895 qn895

Labels

bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@qn895 @elasticmachine @kibanamachine @peteharverson @jgowdyelastic