[Maps] move map embeddable display properties to map settings#86395
Merged
nreese merged 11 commits intoelastic:masterfrom Jan 11, 2021
Merged
[Maps] move map embeddable display properties to map settings#86395nreese merged 11 commits intoelastic:masterfrom
nreese merged 11 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
nreese
commented
Dec 17, 2020
| @@ -1,143 +0,0 @@ | |||
|
|
|||
| ### Map specific `input` parameters | |||
Contributor
Author
There was a problem hiding this comment.
Removing this readme. Its pretty out dated and not really needed now that map embeddable is typed.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
shahzad31
approved these changes
Jan 4, 2021
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
thomasneirynck
approved these changes
Jan 11, 2021
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
thx, nice cleanup
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 11, 2021
…c#86395) * [Maps] move map embeddable display properties to map settings * update uptime EmbeddedMap * tslint * more cleanup Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Jan 12, 2021
#87944) * [Maps] move map embeddable display properties to map settings * update uptime EmbeddedMap * tslint * more cleanup Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disableInteractive, disableTooltipControl, hideToolbarOverlay, hideLayerControl, and hideViewControl were exposed by map embeddable to allow uptime to have a non-interactive map. They were added as top level map properties at the time. Since that time, maps has added a mapSettings section that is a better home for these configurations. This PR moves these top level settings to mapSettings to reduce clutter in mapEmbeddableInput interface and redux store interface. This PR is just moving were configuration is stored and should have not effect on functionality.