Skip to content

[Monitoring] Convert Kibana-related server files that read from _source to typescript#86364

Merged
chrisronline merged 6 commits intoelastic:masterfrom
chrisronline:monitoring/ecs_kibana
Dec 22, 2020
Merged

[Monitoring] Convert Kibana-related server files that read from _source to typescript#86364
chrisronline merged 6 commits intoelastic:masterfrom
chrisronline:monitoring/ecs_kibana

Conversation

@chrisronline
Copy link
Copy Markdown
Contributor

Relates to #84370

This PR updates a couple source files used for Kibana monitoring that read from source to using Typescript. This is an attempt to identify all fields read from source to help with #73864

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 17, 2020
@chrisronline chrisronline self-assigned this Dec 17, 2020
@chrisronline chrisronline requested a review from a team December 17, 2020 19:36
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 979.0KB 979.3KB +344.0B

Distributable file count

id before after diff
default 47142 47903 +761

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chrisronline chrisronline merged commit ecb4522 into elastic:master Dec 22, 2020
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 22, 2020
…ce to typescript (elastic#86364)

* Identifying kibana source fields

* Fix types

* Fix types, take 2

* Should really fix it now

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/monitoring/public/components/kibana/instances/instances.js
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 22, 2020
…ce to typescript (elastic#86364)

* Identifying kibana source fields

* Fix types

* Fix types, take 2

* Should really fix it now

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/monitoring/public/components/kibana/instances/instances.js
@chrisronline chrisronline deleted the monitoring/ecs_kibana branch December 22, 2020 02:16
chrisronline added a commit that referenced this pull request Dec 22, 2020
…ce to typescript (#86364) (#86720)

* Identifying kibana source fields

* Fix types

* Fix types, take 2

* Should really fix it now

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/monitoring/public/components/kibana/instances/instances.js
chrisronline added a commit that referenced this pull request Dec 22, 2020
…ce to typescript (#86364) (#86721)

* Identifying kibana source fields

* Fix types

* Fix types, take 2

* Should really fix it now

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/monitoring/public/components/kibana/instances/instances.js
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 22, 2020
* master: (36 commits)
  update apm index pattern (elastic#86739)
  [Visualizations] Remove vis_default_editor - visualize plugins cyclic dependencies (elastic#85422)
  [ML] Fix alignment of values in data frame analytics results view badges (elastic#86621)
  [Visualizations] Remove charts - editor plugins cyclic dependencies (elastic#84887)
  fixing blank page (elastic#86640)
  Update dependency vega to ^5.17.1 (elastic#86715)
  [Monitoring] Convert Kibana-related server files that read from _source to typescript (elastic#86364)
  Uses @elastic/elasticsearch-canary (elastic#86398)
  [CI] Removes script previously used for Karma (elastic#86412)
  [build] Remove grunt checkPlugins task (elastic#85852)
  [build] Remove grunt docker:docs task (elastic#85848)
  [ML] Add doc link for classification AUC ROC evaluation (elastic#86660)
  [ML] Edits saved object synchronization message (elastic#86664)
  Uses the new es client in canvas usage collector's fetch methods (elastic#86668)
  [ML] Support legacy watcher URL (elastic#86661)
  [ML] Fix Single Metric Viewer y domain extending beyond the visible focus area (elastic#86655)
  Migrates search telemetry usage collector es client from legacy to new (elastic#86597)
  [Alerting] Encourage type safe usage of Alerting (elastic#86623)
  Migrates kql_telemetry usage collector es client (elastic#86585)
  [ML] Fix time range adjustment for the swim lane causing the infinite loop update (elastic#86461)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.11.0 v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants