Flaky test fix for Actions and Triggers app alerts should delete all selection #86175
Merged
YulNaumenko merged 9 commits intoelastic:masterfrom Jan 5, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
mikecote
reviewed
Dec 18, 2020
Contributor
mikecote
left a comment
There was a problem hiding this comment.
Changes look good so far. It looks like there's still some flakiness so I will wait on finishing my review.
| it('should delete all selection', async () => { | ||
| const namePrefix = generateUniqueKey(); | ||
| let count = 0; | ||
| const createdAlertsFirstPage = await Promise.all( |
Contributor
There was a problem hiding this comment.
Since we're only creating one alert, we can cleanup some of the looping logic at the same time.
Suggested change
| const createdAlertsFirstPage = await Promise.all( | |
| const createdAlert = await createAlert({ name: `${namePrefix}-1` }); |
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Jan 5, 2021
…selection (elastic#86175) * Removed skip test for delete all alerts integration test * fixed typechecks * reduced nuber of selected alert to delete to a single one * fixed due to comments * removed long timing retry * fixed typechecks * fixed failing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts·ts - Actions and Triggers app alerts should delete all selection #77401.