Skip to content

[Security Solution] Add Pinned Event tabs on Timeline#85905

Merged
angorayc merged 30 commits intoelastic:masterfrom
XavierM:timeline-pinned-events
Dec 16, 2020
Merged

[Security Solution] Add Pinned Event tabs on Timeline#85905
angorayc merged 30 commits intoelastic:masterfrom
XavierM:timeline-pinned-events

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Dec 15, 2020

Summary

Add Pinned Events in timeline

image

@XavierM XavierM added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Dec 15, 2020
@XavierM XavierM self-assigned this Dec 15, 2020
@XavierM XavierM requested review from a team as code owners December 15, 2020 05:02
@XavierM XavierM added the Feature:Timeline Security Solution Timeline feature label Dec 15, 2020
@angorayc
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@angorayc
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@andrew-goldstein
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

merge conflict between base and head

@cnasikas
Copy link
Copy Markdown
Member

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

merge conflict between base and head

@elastic elastic deleted a comment from kibanamachine Dec 16, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2163 2164 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +22.4KB

Distributable file count

id before after diff
default 47280 48043 +763
Unknown metric groups

async chunk count

id before after diff
securitySolution 23 24 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit 0586c06 into elastic:master Dec 16, 2020
angorayc added a commit to angorayc/kibana that referenced this pull request Dec 16, 2020
* wip

* finish drag & drop from pinned events + fix top n

* Fix types

* update cypress

* Fix unit tests

* fix cypress test

* fix filter out/in

* remove unused components

* fix pagination cypress test

* cypress timelines selectors

* review and skip cypress test

* more to skip

* fix type

* skip case

* Fix types

* Fix tests

* skip resolver

* only query pinned events

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
angorayc added a commit to angorayc/kibana that referenced this pull request Dec 16, 2020
* wip

* finish drag & drop from pinned events + fix top n

* Fix types

* update cypress

* Fix unit tests

* fix cypress test

* fix filter out/in

* remove unused components

* fix pagination cypress test

* cypress timelines selectors

* review and skip cypress test

* more to skip

* fix type

* skip case

* Fix types

* Fix tests

* skip resolver

* only query pinned events

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
XavierM added a commit that referenced this pull request Dec 17, 2020
* wip

* finish drag & drop from pinned events + fix top n

* Fix types

* update cypress

* Fix unit tests

* fix cypress test

* fix filter out/in

* remove unused components

* fix pagination cypress test

* cypress timelines selectors

* review and skip cypress test

* more to skip

* fix type

* skip case

* Fix types

* Fix tests

* skip resolver

* only query pinned events

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
XavierM added a commit that referenced this pull request Dec 17, 2020
* wip

* finish drag & drop from pinned events + fix top n

* Fix types

* update cypress

* Fix unit tests

* fix cypress test

* fix filter out/in

* remove unused components

* fix pagination cypress test

* cypress timelines selectors

* review and skip cypress test

* more to skip

* fix type

* skip case

* Fix types

* Fix tests

* skip resolver

* only query pinned events

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Timeline Security Solution Timeline feature release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants