[ML] Adding job sychronization warning to job list pages#85794
Conversation
| initSavedObjects(true) | ||
| .then(({ jobs }) => { | ||
| const missingJobs = jobType === undefined || jobs.some(({ type }) => type === jobType); | ||
| setShowWarning(missingJobs); |
There was a problem hiding this comment.
this effect potentially can update the state of an unmounted component
There was a problem hiding this comment.
Isn't this the case for all async calls that are made from a useEffect?
Normally we call an async function but do not await on it as you can't pass an async function to useEffect, here I decided to use a then rather than create a second function.
This is a pattern i've seen in plenty of places, is there a better alternative?
There was a problem hiding this comment.
Check out this example
, I don't know if there is a better wayThere was a problem hiding this comment.
ok yeah, a lock like this is a good solution.
We have a lot of components which have this potential problem.
There was a problem hiding this comment.
yes, you're right, I see a warning message from React on this issue quite often.
x-pack/plugins/ml/public/application/components/saved_objects_warning/saved_objects_warning.tsx
Show resolved
Hide resolved
|
Pinging @elastic/ml-ui (:ml) |
|
Not related to this PR, but I got this error when trying to run Synchronize. I think you can reproduce by:
|
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest edits and LGTM
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
retest |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
…6088) * [ML] Adding job sychronization warning to job list pages * fixing overview page callout * improving check logic * adding render lock Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
When loading the Overview, Anomaly Detection and Data Frame Analytics pages, a synchronization check is run to see if any jobs are missing their save objects.
A callout is then displayed with a link to the stack management page so the user can repair them,
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
This was checked for breaking API changes and was labeled appropriately