Skip to content

[APM] Add sanitize_field_names and transaction_ignore_urls config options to Ruby agent#85646

Merged
sorenlouv merged 2 commits intoelastic:masterfrom
mikker:remote-config
Dec 16, 2020
Merged

[APM] Add sanitize_field_names and transaction_ignore_urls config options to Ruby agent#85646
sorenlouv merged 2 commits intoelastic:masterfrom
mikker:remote-config

Conversation

@mikker
Copy link
Copy Markdown

@mikker mikker commented Dec 10, 2020 •
edited
Loading

@mikker mikker requested a review from a team December 10, 2020 21:12
@mikker mikker self-assigned this Dec 10, 2020
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Dec 10, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 10, 2020

Pinging @elastic/apm-ui (Team:apm)

@mikker mikker mentioned this pull request Dec 10, 2020
Closed
@mikker mikker changed the title [APM] Add sanitize_field_names config option to Ruby agent [APM] Add sanitize_field_names and transaction_ignore_urls config option to Ruby agent Dec 14, 2020
@mikker mikker changed the title [APM] Add sanitize_field_names and transaction_ignore_urls config option to Ruby agent [APM] Add sanitize_field_names and transaction_ignore_urls config options to Ruby agent Dec 14, 2020
@mikker
Copy link
Copy Markdown
Author

mikker commented Dec 15, 2020

@sqren This ok to merge?

@sorenlouv
Copy link
Copy Markdown
Contributor

sorenlouv commented Dec 15, 2020

@elasticmachine merge upstream

@sorenlouv
Copy link
Copy Markdown
Contributor

sorenlouv commented Dec 15, 2020

This ok to merge?

Ok to merge when CI passes. Not sure what the problem is but tried to kick it. Let's see

@smith
Copy link
Copy Markdown
Contributor

smith commented Dec 15, 2020

API test failures were due to 503s.

retest

@smith
Copy link
Copy Markdown
Contributor

smith commented Dec 15, 2020

retest

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 16, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB +7.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit 39543e8 into elastic:master Dec 16, 2020
@sorenlouv sorenlouv mentioned this pull request Dec 16, 2020
Merged
@mikker mikker deleted the remote-config branch December 16, 2020 09:09
sorenlouv added a commit that referenced this pull request Dec 17, 2020
@sorenlouv @kibanamachine
[APM] Add sanitize_field_names and transaction_ignore_urls config opt…
8fce386 
…ions to Ruby agent (#85646) (#86084)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Mikkel Malmberg <mikkel@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sorenlouv sorenlouv sorenlouv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikker mikker

Labels

release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure transaction_ignore_urls is centrally configurable [META 319] Add sanitize_field_names to remote config

5 participants

@mikker @elasticmachine @sorenlouv @smith @kibanamachine