Fixes Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should show save confirmation before creating alert with no actions#85623
Merged
ymao1 merged 5 commits intoelastic:masterfrom Dec 16, 2020
Merged
Conversation
ymao1
commented
Dec 16, 2020
| it('should show save confirmation before creating alert with no actions', async () => { | ||
| const alertName = generateUniqueKey(); | ||
| await defineAlert(alertName); | ||
| await defineAlwaysFiringAlert(alertName); |
Contributor
Author
There was a problem hiding this comment.
The test would occasionally receive TimeoutError: Waiting for element to be located By(css selector, #indexSelectSearchBox) when defining an index threshold alert before saving.
The same alert is defined in an above test should create an alert with no flakiness so I'm not really sure what's causing the flakiness in this test. Switched to defining a simpler alert with less click interaction for now.
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Dec 16, 2020
…ctional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should show save confirmation before creating alert with no actions (elastic#85623) * Unskipping test * Using simpler alert type during test * Fixing test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ymao1
added a commit
that referenced
this pull request
Dec 16, 2020
…ctional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout·ts - Actions and Triggers app create alert should show save confirmation before creating alert with no actions (#85623) (#86169) * Unskipping test * Using simpler alert type during test * Fixing test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #85105
Summary
Switched to defining a simpler alert with less click interaction for this test
should show save confirmation before creating alert with no actionssince this test is testing for the presence of the save confirmation modalFlaky test runner results