[@kbn/ui-framework] Removes all but dist files#85347
Merged
tylersmalley merged 4 commits intoelastic:masterfrom Dec 10, 2020
Merged
[@kbn/ui-framework] Removes all but dist files#85347tylersmalley merged 4 commits intoelastic:masterfrom
tylersmalley merged 4 commits intoelastic:masterfrom
Conversation
This package has long since been deprecated and no longer maintained. The only reason it still exists is that not all plugins have migrated away from using the kui classes to EUI. This removes all src and build files as a step forward. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Contributor
|
Pinging @elastic/kibana-design (Team:Kibana-Design) |
Member
Author
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
spalger
approved these changes
Dec 9, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
mshustov
approved these changes
Dec 10, 2020
snide
approved these changes
Dec 10, 2020
Contributor
snide
left a comment
There was a problem hiding this comment.
Checked over changes, ran locally and looked against places where KUI was still in use. LGTM.
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Dec 10, 2020
This package has long since been deprecated and no longer maintained. The only reason it still exists is that not all plugins have migrated away from using the kui classes to EUI. This removes all src and build files as a step forward. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # .eslintrc.js # packages/kbn-ui-framework/doc_site/src/components/guide_page/guide_page.js # yarn.lock
tylersmalley
added a commit
that referenced
this pull request
Dec 10, 2020
This package has long since been deprecated and no longer maintained. The only reason it still exists is that not all plugins have migrated away from using the kui classes to EUI. This removes all src and build files as a step forward. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # .eslintrc.js # packages/kbn-ui-framework/doc_site/src/components/guide_page/guide_page.js # yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package has long since been deprecated and no longer maintained. The only reason it still exists is that not all plugins have migrated away from using the kui classes to EUI. This removes all src and build files as a step forward while maintaining the dist which is what is still consumed. This removes
@kbn/ui-frameworkas a build step during bootstrap and gets us one step closer to removing Grunt.Related to #82239
Related to #46410