[Time to Visualize] Fix Lens Save Modal Retaining Originating App Connection#85309
Merged
ThomThomson merged 2 commits intoelastic:masterfrom Dec 10, 2020
Merged
Conversation
…ction after it has been severed
8 tasks
Contributor
|
The fix looks good to me but I think the implementation has to be updated based on @poffdeluxe s changes. |
…oardLinkageNotLost
Contributor
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts.lens app lens smokescreen tests should create an xy visualization with filters aggregationStandard OutStack TraceMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Dec 10, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested in Chrome and works as expected, LGTM
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Dec 10, 2020
…ction after it has been severed (elastic#85309)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Lens save modal was using the
originatingAppargument directly from its incoming state, when the rest of the lens app uses its own stateisLinkedToOriginatingAppin order to avoid mutating the incoming state directly.The save modal has been updated to use the
isLinkedToOriginatingAppargument instead.Checklist
Delete any items that are not applicable to this PR.
For maintainers