Skip to content

Removes Grunt abstraction from CI tasks#85210

Merged
tylersmalley merged 1 commit intoelastic:masterfrom
tylersmalley:remove-grunt
Dec 9, 2020
Merged

Removes Grunt abstraction from CI tasks#85210
tylersmalley merged 1 commit intoelastic:masterfrom
tylersmalley:remove-grunt

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Dec 7, 2020 •
edited
Loading

Steps towards the eventual goal of removing Grunt.

Related to #85341

After:

Running "availabletasks:availabletasks" (availabletasks) task
availabletasks                           ->  List available Grunt tasks & targets. 
babel                                    ->  Use next generation JavaScript, today 
checkPlugins                             =>  Checks for plugins which may disrupt tests 
clean                                    ->  Clean files and folders. 
copy                                     ->  Copy files. 
docker:docs                              =>  Build docs from docker 
functionalTests:ensureAllTestsInCiGroup  =>  Check that all of the functional tests are in a CI group 
licenses:csv_report                      =>  Report of 3rd party dependencies 
peg                                      ->  Generates parsers from PEG grammars. (kuery|timelion_chain)
tasks                                    =>  Alias for "availabletasks" task. 
watch                                    >   Run predefined tasks whenever watched files change.

@tylersmalley tylersmalley force-pushed the remove-grunt branch 5 times, most recently from 3d8c7a8 to 2928a60 Compare December 8, 2020 20:48
@tylersmalley tylersmalley mentioned this pull request Dec 8, 2020
Closed
8 tasks
@tylersmalley tylersmalley force-pushed the remove-grunt branch 3 times, most recently from 637c8d2 to 66d0480 Compare December 8, 2020 21:19
@tylersmalley
Removes Grunt abstraction from CI tasks
0ef51fc 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 8, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB -69.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 60.4KB 60.4KB -69.0B

History

  • 💔 Build #92901 failed ca117a7fe7a1028e4e4a114d700fd24d66f150a4
  • 💚 Build #92862 succeeded 3d8c7a828406f10a41c21474757c15c68471b141
  • 💔 Build #92890 failed 2928a60b83a924527d756ae029ee3c2e235db766
  • 💚 Build #92829 succeeded bc65cfc654d5dba8bc89161505cbe1c1336c8ca6
  • 💔 Build #92810 failed 7a2a743c18a5fd3672813ab6ce315d266622eb33

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley marked this pull request as ready for review December 8, 2020 23:10
@tylersmalley tylersmalley requested a review from a team as a code owner December 8, 2020 23:10
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.11.0 v8.0.0 labels Dec 8, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 8, 2020

Pinging @elastic/kibana-operations (Team:Operations)

spalger
spalger reviewed Dec 8, 2020
View reviewed changes
spalger
spalger approved these changes Dec 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, all the test results and pipeline steps seem to be there, LGTM

@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented Dec 8, 2020

@brianseeders, mind also taking a look since I touched on a lot of TeamCity here?

brianseeders
brianseeders approved these changes Dec 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can fix up any TeamCity problems after merge, if there are any, since you can't really test it easily atm

@tylersmalley tylersmalley merged commit 9b62100 into elastic:master Dec 9, 2020
@tylersmalley tylersmalley mentioned this pull request Dec 9, 2020
Merged
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Dec 9, 2020
@tylersmalley
Removes Grunt abstraction from CI tasks (elastic#85210)
caaad85 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	tasks/config/run.js
#	test/scripts/jenkins_ci_group.sh
#	test/scripts/jenkins_unit.sh
@tylersmalley tylersmalley mentioned this pull request Dec 9, 2020
Merged
tylersmalley added a commit that referenced this pull request Dec 9, 2020
@tylersmalley @kibanamachine
[7.x] Removes Grunt abstraction from CI tasks (#85210) (#85448)
0c9a3c0 
* Removes Grunt abstraction from CI tasks (#85210)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	tasks/config/run.js
#	test/scripts/jenkins_ci_group.sh
#	test/scripts/jenkins_unit.sh

* [CI] Set correct script execute permissions (#85475)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianseeders brianseeders brianseeders approved these changes

+1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tylersmalley @kibanamachine @elasticmachine @brianseeders @spalger