[ILM] Moved error and loading notices for data allocation#85154
[ILM] Moved error and loading notices for data allocation#85154jloleysens merged 6 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
| break; | ||
| default: | ||
| return null; | ||
| const { data, resendRequest, error, isLoading } = useLoadNodes(); |
There was a problem hiding this comment.
Delete error here and on the line below it add:
const error = new Error('test')
to see the erroring state.
yuliacech
left a comment
There was a problem hiding this comment.
Hi @jloleysens , great job on refactoring data tier allocation! As discussed, the input element could potentially react to error / loading states as well.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@yuliacech I've added loading spinners to inputs to indicate that something is still loading:
Would you mind taking another look? |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
yuliacech
left a comment
There was a problem hiding this comment.
Thanks for addressing my feedback, @jloleysens ! tested locally and changes LGTM!
) * moved error and loading notices for data allocation field to below description * removed test code * expect controls to be showing, only render notice after network request has finished * added loading spinner for field inputs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…85564) * moved error and loading notices for data allocation field to below description * removed test code * expect controls to be showing, only render notice after network request has finished * added loading spinner for field inputs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Minor fix for layout of error notice regarding loading node data in data allocation field. No logic changes were introduced for when/how notifications are shown for data allocation field.
How to test
Easiest way to test is to simply always error by checking out this PR and modifying the code. See comment in PRs changes in x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/data_tier_allocation_field/data_tier_allocation_field.tsx
Before
After