[Security Solution] Fixes some misconfigured settings#85056
Merged
rylnd merged 2 commits intoelastic:masterfrom Dec 4, 2020
Merged
[Security Solution] Fixes some misconfigured settings#85056rylnd merged 2 commits intoelastic:masterfrom
rylnd merged 2 commits intoelastic:masterfrom
Conversation
These paths (or rather their absence) breaks the functional_tests_server script. An analogous problem for cases was fixed in elastic#79127.
This context is already provided to the logger by kibana; adding it a second time leads to duplicated log tags, e.g.: ``` server log [12:36:07.138] [debug][plugins][plugins][securitySolution][securitySolution] ... ``` This is now fixed: ``` server log [12:41:52.112] [debug][plugins][securitySolution] ... ```
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
dplumlee
approved these changes
Dec 4, 2020
rylnd
added a commit
that referenced
this pull request
Dec 5, 2020
* Remove nonexistent paths from our API tests config These paths (or rather their absence) breaks the functional_tests_server script. An analogous problem for cases was fixed in #79127. * Remove duplicated context from logger This context is already provided to the logger by kibana; adding it a second time leads to duplicated log tags, e.g.: ``` server log [12:36:07.138] [debug][plugins][plugins][securitySolution][securitySolution] ... ``` This is now fixed: ``` server log [12:41:52.112] [debug][plugins][securitySolution] ... ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses two minor bugs that are logically independent, but both fall generally under "configuration issues," and are tiny, so I've put them together here:
For maintainers