[ingest/register_fields_capabilities] prevent calling reply() twice#8505
Merged
spalger merged 1 commit intoelastic:masterfrom Oct 13, 2016
Merged
Conversation
Contributor
|
Passing selenium tests: https://kibana-ci.elastic.co/view/All/job/elastic+kibana+pull-request+multijob-selenium/384/ LGTM |
Contributor
|
LGTM, subtle change 😃 |
elastic-jasper
added a commit
that referenced
this pull request
Oct 13, 2016
--------- **Commit 1:** [ingest/register_fields_capabilities] prevent calling reply() twice * Original sha: e06e659 * Authored by spalger <email@spalger.com> on 2016-09-30T12:29:46Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 13, 2016
--------- **Commit 1:** [ingest/register_fields_capabilities] prevent calling reply() twice * Original sha: e06e659 * Authored by spalger <email@spalger.com> on 2016-09-30T12:29:46Z
spalger
added a commit
that referenced
this pull request
Oct 13, 2016
[backport] PR #8505 to 5.0 - [ingest/register_fields_capabilities] prevent calling reply() twice
spalger
added a commit
that referenced
this pull request
Oct 13, 2016
[backport] PR #8505 to 5.x - [ingest/register_fields_capabilities] prevent calling reply() twice
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8505 to 5.x - [ingest/register_fields_capabilities] prevent calling reply() twice Former-commit-id: 2dc8063
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduce:
api/kibana/field_capabilitiescallThe catch handler currently in the code prevents the error from propogating, because it it handled by the
handleESError()function. This causes thethen()callback to execute and try to send a second response.