Integrate painless autocomplete in runtime fields editor#84943
Merged
alisonelizabeth merged 5 commits intoelastic:masterfrom Dec 7, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
yuliacech
approved these changes
Dec 7, 2020
Contributor
yuliacech
left a comment
There was a problem hiding this comment.
Hi @alisonelizabeth , great job on adding autocomplete to runtime fields editor! I tested locally and all worked for me, changes in code LGTM too 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates painless autocompletion in the runtime fields editor.
Continuation of #80577.
How to test
Verify autocomplete functionality is working in the runtime field editor. The runtime field editor is currently only integrated in the composable index template, legacy index template, and component template wizards.
For a list of available autocomplete functionality, check out the "Testing" section in #80577.
In order to test field autocompletion, you need to create at least one mapped field.
Known issues
I've received some feedback already around improvements that can be made to the autocomplete. I will handle these in a separate PR (#85055):
emit()andparamstextfield types from the field autocomplete suggestions;textfield types are never in doc values.