test:jest improvements to better support our monorepo#84848
Merged
tylersmalley merged 4 commits intoelastic:masterfrom Dec 14, 2020
Merged
test:jest improvements to better support our monorepo#84848tylersmalley merged 4 commits intoelastic:masterfrom
tylersmalley merged 4 commits intoelastic:masterfrom
Conversation
1 task
2e4a8e2 to
87b3b9b
Compare
0de2f02 to
81e2176
Compare
c350d21 to
d591472
Compare
cbb1bd9 to
e195cc2
Compare
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
e195cc2 to
8364444
Compare
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
pgayvallet
approved these changes
Dec 11, 2020
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
legrego
approved these changes
Dec 13, 2020
Member
legrego
left a comment
There was a problem hiding this comment.
Changes to x-pack/plugins/encrypted_saved_objects/README.md LGTM 🎉
peteharverson
approved these changes
Dec 14, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Changes to ML and Transforms READMEs LGTM
shahzad31
approved these changes
Dec 14, 2020
Contributor
shahzad31
left a comment
There was a problem hiding this comment.
Awesome, looks so much clean
Member
Author
|
@elasticmachine merge upstream |
cee-chen
approved these changes
Dec 14, 2020
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
Woo hoo! Enterprise Search team is super excited for this :)
jbudz
approved these changes
Dec 14, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Dec 14, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # docs/developer/contributing/development-functional-tests.asciidoc # test/scripts/jenkins_unit.sh # test/scripts/jenkins_xpack.sh # x-pack/README.md
tylersmalley
added a commit
that referenced
this pull request
Dec 15, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # docs/developer/contributing/development-functional-tests.asciidoc # test/scripts/jenkins_unit.sh # test/scripts/jenkins_xpack.sh # x-pack/README.md Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the
yarn test:jestscript to provide a better testing experience while navigating throughout the monorepo. To run the tests within your current working directory, useyarn test:jest. Like the Jest CLI, you can also supply a path to determine which tests to run. The best-suited Jest configuration will be selected based on your current working directory, or the path provided to ensure the tests start as quickly as possible. Any additional arguments are passed onto the Jest CLI, like--coverage.Details are available in the updated docs: https://kibana_84848.docs-preview.app.elstc.co/guide/en/kibana/master/development-tests.html#_unit_testing
This removes any differences there was between how unit tests are run in OSS or X-Pack.