Skip to content

Fixed a11y issue on rollup jobs table selection#84567

Merged
yuliacech merged 2 commits intoelastic:masterfrom
yuliacech:rollup_jobs_a11y_checkbox_fix
Dec 3, 2020
Merged

Fixed a11y issue on rollup jobs table selection#84567
yuliacech merged 2 commits intoelastic:masterfrom
yuliacech:rollup_jobs_a11y_checkbox_fix

Conversation

@yuliacech
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech commented Nov 30, 2020 •
edited
Loading

Resolves #28301

Summary

This PR adds an aria-label to row selection checkboxes in the rollup jobs table. For an individual row selection, the screen reader pronounces 'select this row' + name of the job. For all rows selection, it says 'Select all rows'.

How to test

  1. Enable Voice over on macOS (how-to) or install a screen reader extension for the browser (ChromeVox for Chrome)
  2. Create an index in DevTools
POST /my-index/_doc/
{
  "@timestamp": "2020-12-06T11:04:05.000Z",
  "user": {
    "id": "vlb44hny"
  },
  "message": "Login attempt failed"
}
  1. Navigate to 'Stack Management' -> 'Rollup Jobs' and create a new rollup job for the created index.
  2. With screen reader/voice over enabled, try selecting/unselecting rows in the rollup jobs table.

Release note

Accessibility fix in Rollup Jobs app: when selecting a row in the jobs table, a screen reader pronounces the job's name.

@yuliacech yuliacech added v7.11.0 v8.0.0 Feature:Rollups Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:enhancement labels Dec 1, 2020
@yuliacech yuliacech marked this pull request as ready for review December 1, 2020 09:32
@yuliacech yuliacech requested a review from a team as a code owner December 1, 2020 09:32
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 1, 2020

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@yuliacech yuliacech requested a review from jloleysens December 1, 2020 09:37
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 1, 2020

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@cjcenizal
Copy link
Copy Markdown
Contributor

cjcenizal commented Dec 1, 2020

I think we should consider this a bugfix, since accessibility gaps are bugs.

@yuliacech
Copy link
Copy Markdown
Contributor Author

yuliacech commented Dec 2, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 2, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
rollup 268.8KB 269.1KB +298.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens
jloleysens approved these changes Dec 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as expected!

@yuliacech yuliacech merged commit bec3342 into elastic:master Dec 3, 2020
yuliacech added a commit to yuliacech/kibana that referenced this pull request Dec 3, 2020
@yuliacech @kibanamachine
Fixed a11y issue on rollup jobs table selection (elastic#84567)
6e5e82b 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@yuliacech yuliacech mentioned this pull request Dec 3, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 3, 2020
@gmmorris
Merge branch 'master' into alerts/force-schedule
ffcc5ca 
* master: (40 commits)
  fix: 🐛 don't add separator befor group on no main items (elastic#83166)
  [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323)
  [APM] Add APM agent config options (elastic#84678)
  Fixed a11y issue on rollup jobs table selection (elastic#84567)
  [Discover] Refactor getContextUrl to separate file (elastic#84503)
  [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654)
  [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749)
  [Lens] Migrate legacy es client and remove total hits as int (elastic#84340)
  Improve logging pipeline in @kbn/legacy-logging (elastic#84629)
  Catch @hapi/podium errors (elastic#84575)
  [Discover] Unskip date histogram test (elastic#84727)
  Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791)
  [Enterprise Search] Fix schema errors button (elastic#84842)
  [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589)
  [Maps] Always initialize routes on server-startup (elastic#84806)
  [Fleet] EPM support to handle uploaded file paths (elastic#84708)
  [Snapshot Restore] Fix initial policy form state (elastic#83928)
  Upgrade Node.js to version 14 (elastic#83425)
  [Security Solution] Keep Endpoint policies up to date with license changes (elastic#83992)
  [Security Solution][Exceptions] Implement exceptions for ML rules (elastic#84006)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 3, 2020
@gmmorris
Merge branch 'master' into alerts/flaky-event-log-tests
5cce0f7 
* master: (236 commits)
  fix: 🐛 don't add separator befor group on no main items (elastic#83166)
  [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323)
  [APM] Add APM agent config options (elastic#84678)
  Fixed a11y issue on rollup jobs table selection (elastic#84567)
  [Discover] Refactor getContextUrl to separate file (elastic#84503)
  [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654)
  [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749)
  [Lens] Migrate legacy es client and remove total hits as int (elastic#84340)
  Improve logging pipeline in @kbn/legacy-logging (elastic#84629)
  Catch @hapi/podium errors (elastic#84575)
  [Discover] Unskip date histogram test (elastic#84727)
  Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791)
  [Enterprise Search] Fix schema errors button (elastic#84842)
  [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589)
  [Maps] Always initialize routes on server-startup (elastic#84806)
  [Fleet] EPM support to handle uploaded file paths (elastic#84708)
  [Snapshot Restore] Fix initial policy form state (elastic#83928)
  Upgrade Node.js to version 14 (elastic#83425)
  [Security Solution] Keep Endpoint policies up to date with license changes (elastic#83992)
  [Security Solution][Exceptions] Implement exceptions for ML rules (elastic#84006)
  ...
yuliacech added a commit to yuliacech/kibana that referenced this pull request Dec 3, 2020
@yuliacech @kibanamachine
Fixed a11y issue on rollup jobs table selection (elastic#84567)
3b3bfa0 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@yuliacech yuliacech mentioned this pull request Dec 3, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 3, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master' into alerts/custom-rec…
7762864 
…overy-action-group

* upstream/master: (48 commits)
  [Lens] accessibility screen reader issues (elastic#84395)
  [Logs UI] Fetch single log entries via a search strategy (elastic#81710)
  fix: 🐛 don't add separator befor group on no main items (elastic#83166)
  [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323)
  [APM] Add APM agent config options (elastic#84678)
  Fixed a11y issue on rollup jobs table selection (elastic#84567)
  [Discover] Refactor getContextUrl to separate file (elastic#84503)
  [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654)
  [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749)
  [Lens] Migrate legacy es client and remove total hits as int (elastic#84340)
  Improve logging pipeline in @kbn/legacy-logging (elastic#84629)
  Catch @hapi/podium errors (elastic#84575)
  [Discover] Unskip date histogram test (elastic#84727)
  Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791)
  [Enterprise Search] Fix schema errors button (elastic#84842)
  [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589)
  [Maps] Always initialize routes on server-startup (elastic#84806)
  [Fleet] EPM support to handle uploaded file paths (elastic#84708)
  [Snapshot Restore] Fix initial policy form state (elastic#83928)
  Upgrade Node.js to version 14 (elastic#83425)
  ...
yuliacech added a commit that referenced this pull request Dec 3, 2020
@yuliacech @kibanamachine
Fixed a11y issue on rollup jobs table selection (#84567) (#84880)
7c4ec08 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
yuliacech added a commit that referenced this pull request Dec 3, 2020
@yuliacech @kibanamachine
Fixed a11y issue on rollup jobs table selection (#84567) (#84886)
3a1e352 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@yuliacech yuliacech deleted the rollup_jobs_a11y_checkbox_fix branch February 24, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees

No one assigned

Labels

Feature:Rollups Project:Accessibility release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.10.2 v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(Accessibility) Rollup Jobs list checkboxes missing labels

5 participants

@yuliacech @elasticmachine @cjcenizal @kibanamachine @jloleysens