Skip to content

[7.x] Trusted Apps signer API. (#83661)#84516

Merged
efreeti merged 1 commit intoelastic:7.xfrom
efreeti:backport/7.x/pr-83661
Nov 30, 2020
Merged

[7.x] Trusted Apps signer API. (#83661)#84516
efreeti merged 1 commit intoelastic:7.xfrom
efreeti:backport/7.x/pr-83661

Conversation

@efreeti
Copy link
Copy Markdown
Contributor

@efreeti efreeti commented Nov 30, 2020

Backports the following commits to 7.x:

* Separated out service layer for trusted apps.

* Improved the type structure a bit to avoid using explicit string literals and to add possibility to return OS specific parts of trusted app object in type safe manner.

* Added support for mapping of trusted app to exception item and back.

* Changed schema to support signer in the API.

* Renamed utils to mapping.

* Exported some types in lists plugin and used them in trusted apps.

* Added tests for mapping.

* Added tests for service.

* Switched deletion to use exceptions for not found case.

* Added resetting of the mocks in service layer tests.

* Added handlers tests.

* Refactored mapping tests to be more granular based on the case.

* Restored lowercasing of hash.

* Added schema tests for signer field.

* Removed the grouped tests (they were split into tests for separate concerns).

* Corrected the tests.

* Lowercased the hashes in the service test.

* Moved the lowercasing to the right location.

* Fixed the tests.

* Added test for lowercasing hash value.

* Introduced OperatingSystem enum instead of current types.

* Removed os list constant in favour of separate lists in places that use it (each place has own needs to the ordering).

* Fixed the missed OperatingSystem enum usage.
@efreeti efreeti added the backport This PR is a backport of another PR label Nov 30, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.0MB 8.0MB -882.0B

Distributable file count

id before after diff
default 43475 43476 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lists 173.5KB 173.6KB +117.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@efreeti efreeti merged commit a45420a into elastic:7.x Nov 30, 2020
@efreeti efreeti deleted the backport/7.x/pr-83661 branch November 30, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants