Skip to content

Commit f2d59ef

Browse files
efreetiefreeti
committed
Trusted Apps signer API. (#83661)
* Separated out service layer for trusted apps. * Improved the type structure a bit to avoid using explicit string literals and to add possibility to return OS specific parts of trusted app object in type safe manner. * Added support for mapping of trusted app to exception item and back. * Changed schema to support signer in the API. * Renamed utils to mapping. * Exported some types in lists plugin and used them in trusted apps. * Added tests for mapping. * Added tests for service. * Switched deletion to use exceptions for not found case. * Added resetting of the mocks in service layer tests. * Added handlers tests. * Refactored mapping tests to be more granular based on the case. * Restored lowercasing of hash. * Added schema tests for signer field. * Removed the grouped tests (they were split into tests for separate concerns). * Corrected the tests. * Lowercased the hashes in the service test. * Moved the lowercasing to the right location. * Fixed the tests. * Added test for lowercasing hash value. * Introduced OperatingSystem enum instead of current types. * Removed os list constant in favour of separate lists in places that use it (each place has own needs to the ordering). * Fixed the missed OperatingSystem enum usage.
1 parent f866385 commit f2d59ef

30 files changed

Lines changed: 1430 additions & 1037 deletions

File tree

‎x-pack/plugins/lists/common/shared_exports.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export {
2323
EntryList,
2424
EntriesArray,
2525
NamespaceType,
26+
NestedEntriesArray,
2627
Operator,
2728
OperatorEnum,
2829
OperatorTypeEnum,

‎x-pack/plugins/lists/server/index.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import { ListPlugin } from './plugin';
1111

1212
// exporting these since its required at top level in siem plugin
1313
export { ListClient } from './services/lists/list_client';
14+
export { CreateExceptionListItemOptions } from './services/exception_lists/exception_list_client_types';
1415
export { ExceptionListClient } from './services/exception_lists/exception_list_client';
1516
export { ListPluginSetup } from './types';
1617

‎x-pack/plugins/security_solution/common/endpoint/constants.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export const telemetryIndexPattern = 'metrics-endpoint.telemetry-*';
1414
export const LIMITED_CONCURRENCY_ENDPOINT_ROUTE_TAG = 'endpoint:limited-concurrency';
1515
export const LIMITED_CONCURRENCY_ENDPOINT_COUNT = 100;
1616

17-
export const TRUSTED_APPS_SUPPORTED_OS_TYPES: readonly string[] = ['macos', 'windows', 'linux'];
1817
export const TRUSTED_APPS_LIST_API = '/api/endpoint/trusted_apps';
1918
export const TRUSTED_APPS_CREATE_API = '/api/endpoint/trusted_apps';
2019
export const TRUSTED_APPS_DELETE_API = '/api/endpoint/trusted_apps/{id}';

0 commit comments

Comments
 (0)