[Lens] Fix label input debouncing#84121
Merged
flash1293 merged 2 commits intoelastic:masterfrom Nov 25, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
approved these changes
Nov 25, 2020
Contributor
mbondyra
left a comment
There was a problem hiding this comment.
tested in Chrome, works fine 👍
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Nov 25, 2020
flash1293
added a commit
that referenced
this pull request
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83818
In some places where debounced inputs where used, we were listening for changes coming from upstream as well using an effect hook. This helps if the same state is changed somewhere else and the input needs to be updated, but it can cause the weird typing issue seen in the original issue, because of this process:
Scenario: User types "abc", waits for 280ms before typing "de", then waits for 280ms again to type "fg"
What they see: "abcde" appearing, flipping back to "abc", "abcfg" appearing, switching to "abcde", then switching back to "abcfg"
Removing the
useEffectupdating on root state changes fixes this behavior, but introduces a theoretical bug of not reflecting a change somewhere else. However I reviewed the places these inputs are used and we don't have such a case yet. So this is fine for now to fix the bug at hand and we can come back to solve it better once we refactor the state mangement.