Merged
Conversation
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
1 task
pgayvallet
approved these changes
Nov 22, 2020
| * under the License. | ||
| */ | ||
|
|
||
| export { shareWeakReplay } from './share_weak_replay'; |
azasypkin
approved these changes
Nov 23, 2020
Contributor
azasypkin
left a comment
There was a problem hiding this comment.
Spaces plugin changes LGTM.
spalger
reviewed
Nov 23, 2020
| "@kbn/test": "link:../kbn-test", | ||
| "@kbn/utils": "link:../kbn-utils" | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Do you mind installing the editorconfig plugin?
patrykkopycinski
approved these changes
Nov 24, 2020
Contributor
patrykkopycinski
left a comment
There was a problem hiding this comment.
SIEM/Endpoint LGTM
Contributor
💚 Build SucceededMetrics [docs]Module Count
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Nov 24, 2020
* move streams to kbn/std * import streams from kbn/std * fix styles * remove unused shareWeakReplay * move from kbn/std to kbn/utils * import from subfolder since test mocks FS module and not compatible with kbn/utils * remove new line at the end of json file
mshustov
added a commit
that referenced
this pull request
Nov 24, 2020
* move streams to kbn/std * import streams from kbn/std * fix styles * remove unused shareWeakReplay * move from kbn/std to kbn/utils * import from subfolder since test mocks FS module and not compatible with kbn/utils * remove new line at the end of json file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Streams seems to be suitable for
@kbn/utilsas it contains server-side helpers. the initial plan was to place them underkbn/stdbut helpers there are env-agnostic