Fix for x-pack maps functional test to remove the unloading of data#83856
Merged
rashmivkulkarni merged 17 commits intoelastic:masterfrom Nov 23, 2020
Merged
Fix for x-pack maps functional test to remove the unloading of data#83856rashmivkulkarni merged 17 commits intoelastic:masterfrom
rashmivkulkarni merged 17 commits intoelastic:masterfrom
Conversation
…equent tests to pass
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
reviewed
Nov 19, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
Can you also remove the before block from this test. The data is loaded in the index file.
Can you do the same for maps_spaces functional test?
Contributor
Author
|
@elasticmachine merge upstream |
nreese
approved these changes
Nov 23, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
Thanks for cleaning up the maps functional tests.
LGTM
code review
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Nov 23, 2020
…lastic#83856) * fixes elastic#74449 * fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass * changes to how we load/unload data * modified index.js file again to fit the needs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rashmivkulkarni
added a commit
that referenced
this pull request
Nov 24, 2020
…83856) (#84166) * fixes #74449 * fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass * changes to how we load/unload data * modified index.js file again to fit the needs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Nov 30, 2020
…lastic#83856) * fixes elastic#74449 * fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass * changes to how we load/unload data * modified index.js file again to fit the needs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rashmivkulkarni
added a commit
that referenced
this pull request
Dec 1, 2020
…83856) (#84597) * fixes #74449 * fixing maps tests -small fix to remove unloading of data for the subsequent tests to pass * changes to how we load/unload data * modified index.js file again to fit the needs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... for the subsequent maps tests to pass.