Skip to content

Remove the parameter timestamp in /api/telemetry/v2/clusters/_stats#83791

Merged
afharo merged 6 commits intoelastic:masterfrom
afharo:telemetry/remove-timestamp-in-api
Nov 23, 2020
Merged

Remove the parameter timestamp in /api/telemetry/v2/clusters/_stats#83791
afharo merged 6 commits intoelastic:masterfrom
afharo:telemetry/remove-timestamp-in-api

Conversation

@afharo
Copy link
Copy Markdown
Member

@afharo afharo commented Nov 19, 2020

Summary

This PR removes the parameter timestamp from the /api/telemetry/v2/clusters/_stats API. It only existed because of the monitoring telemetry strategy collector, but it is no longer needed.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@afharo afharo marked this pull request as ready for review November 19, 2020 14:53
@afharo afharo requested a review from a team as a code owner November 19, 2020 14:53
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 19, 2020

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@afharo
Copy link
Copy Markdown
Member Author

afharo commented Nov 20, 2020

@elasticmachine merge upstream

@afharo
Copy link
Copy Markdown
Member Author

afharo commented Nov 20, 2020

@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers approved these changes Nov 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only,
LGTM!

@afharo afharo requested a review from a team as a code owner November 20, 2020 16:53
@afharo
Copy link
Copy Markdown
Member Author

afharo commented Nov 23, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 23, 2020

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
telemetry 50.1KB 49.8KB -283.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit df4f475 into elastic:master Nov 23, 2020
@afharo afharo deleted the telemetry/remove-timestamp-in-api branch November 23, 2020 12:09
@afharo afharo mentioned this pull request Nov 23, 2020
Merged
afharo added a commit that referenced this pull request Nov 23, 2020
@afharo @kibanamachine
[7.x] Remove the parameter timestamp in `/api/telemetry/v2/clusters…
e5433f0 
…/_stats` (#83791) (#84065)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/apps/infra/home_page.ts
#	x-pack/test/functional/apps/infra/logs_source_configuration.ts
@afharo afharo mentioned this pull request Nov 30, 2020
Merged
3 tasks
@lukeelmers lukeelmers added the Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// label Oct 1, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 1, 2021

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees

No one assigned

Labels

Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove the parameter timestamp in /api/telemetry/v2/clusters/_stats

6 participants

@afharo @elasticmachine @kibanamachine @pgayvallet @TinaHeiligers @lukeelmers