[ML] Data frame analytics: Adds functionality to map view#83710
[ML] Data frame analytics: Adds functionality to map view#83710alvarezmelissa87 merged 6 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/ml-ui (:ml) |
x-pack/plugins/ml/public/application/data_frame_analytics/pages/job_map/components/controls.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_frame_analytics/analytics_manager.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_frame_analytics/analytics_manager.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I lack the full context here, but if you'd like this to remain always white you can use the $euiColorGhost variable.
There was a problem hiding this comment.
Thanks for the suggestion - updated in 0e95f8993b8184dfdf3f02eaad3b476eda9ac79a
There was a problem hiding this comment.
Change this to border: $euiBorderThin which brings with it the width, style, and color.
There was a problem hiding this comment.
Updated in 0e95f8993b8184dfdf3f02eaad3b476eda9ac79a
There was a problem hiding this comment.
Again, lacking context, this might be replaceable with an $euiBorderRadius unless you are going for some rounder effect.
There was a problem hiding this comment.
Updated in 0e95f8993b8184dfdf3f02eaad3b476eda9ac79a
x-pack/plugins/ml/server/models/data_frame_analytics/analytics_manager.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Would be great if we could get rid of the any here since it's also the data being returned from the function.
There was a problem hiding this comment.
Good call - updated the type in 0e95f8993b8184dfdf3f02eaad3b476eda9ac79a
|
Thanks for taking a look! This has been updated and is ready for another look when you get a chance 🙏 |
ryankeairns
left a comment
There was a problem hiding this comment.
Looks good, thanks for the changes.
|
Changes LGTM 🎉 |
fcd1e2f to
f7957f6
Compare
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/drilldowns/dashboard_to_url_drilldown·ts.dashboard drilldowns Dashboard to URL drilldown should create dashboard to URL drilldown and use it to navigate to discoverStandard OutStack TraceMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
* master: (38 commits) [ML] Data frame analytics: Adds functionality to map view (elastic#83710) Add usage collection for savedObject tagging (elastic#83160) [SECURITY_SOLUTION] 145: Advanced Policy Tests (elastic#82898) [APM] Service overview transactions table (elastic#83429) [ML] Fix Single Metric Viewer not loading if job is metric with no partition (elastic#83880) do not export types from 3rd party modules as 'type' (elastic#83803) [Fleet] Allow to send SETTINGS action (elastic#83707) Fixes Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details·ts - Actions and Triggers app Alert Details Alert Instances renders the active alert instances (elastic#83478) [Uptime]Reduce chart height on monitor detail page (elastic#83777) [APM] Prefer `APIReturnType` over `PromiseReturnType` (elastic#83843) [Observability] Fix telemetry for Observability Overview (elastic#83847) [Alerting] Adds generic UI for the definition of conditions for Action Groups (elastic#83278) ensure workload agg doesnt run until next interval when it fails (elastic#83632) [ILM] Policy form should not throw away data (elastic#83077) [Monitoring] Stop collecting Kibana Usage in bulkUploader (elastic#83546) [TSVB] fix wrong imports (elastic#83798) [APM] Correlations UI POC (elastic#82256) list all the refs in tsconfig.json (elastic#83678) Bump jest (and related packages) to v26.6.3 (elastic#83724) Functional tests - stabilize reporting tests for cloud execution (elastic#83787) ...
Summary
Meta issue with screenshots: #75295
Please add any feedback to the meta issue. Thank you!
This PR is a follow up to #81666.
This PR addresses the following items in the meta issue:
Checklist
Delete any items that are not applicable to this PR.
For maintainers