Expression: Add render mode and use it for canvas interactivity by flash1293 · Pull Request #83559 · elastic/kibana

flash1293 · 2020-11-17T16:53:36Z

This PR adds a new option renderMode to expression loader and renderer params which is passed from the embedding (e.g. Lens embeddable class) to the expression renderer. There it can be used to change the rendering of the chart.

This PR puts the new option into use as well by extending the Lens embeddable input in the same way and using the noInteractivity mode for Lens visualizations embedded in Canvas (because filters don't work there anyway).

The only user facing change is no brush functionality and no pointer cursor on click on Lens charts embedded in Canvas

elasticmachine · 2020-11-18T13:01:13Z

Pinging @elastic/kibana-app (Team:KibanaApp)

elasticmachine · 2020-11-18T13:01:21Z

Pinging @elastic/kibana-presentation (Team:Presentation)

elasticmachine · 2020-11-18T13:01:22Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

ppisljar

code LGTM

clintandrewhall

LGTM!

clintandrewhall · 2020-11-18T16:55:07Z

src/plugins/expressions/public/render.ts

      event: (data) => {
        this.eventsSubject.next(data);
      },
+      getMode: () => {


nit: I'd prefer consistency.

Suggested change

getMode: () => {

getRenderMode: () => {

clintandrewhall · 2020-11-18T16:55:23Z

src/plugins/expressions/server/server.api.md

+    // Warning: (ae-forgotten-export) The symbol "RenderMode" needs to be exported by the entry point index.d.ts
+    //
+    // (undocumented)
+    getMode: () => RenderMode;


Suggested change

getMode: () => RenderMode;

getRenderMode: () => RenderMode;

clintandrewhall · 2020-11-18T16:55:37Z

x-pack/plugins/canvas/canvas_plugin_src/renderers/__stories__/render.tsx

  destroy: () => action('destroy'),
  getElementId: () => 'element-id',
  getFilter: () => 'filter',
+  getMode: () => 'display',


Suggested change

getMode: () => 'display',

getRenderMode: () => 'display',

clintandrewhall · 2020-11-18T16:55:48Z

x-pack/plugins/canvas/public/lib/create_handlers.ts

  getFilter() {
    return '';
  },
+  getMode() {


Suggested change

getMode() {

getRenderMode() {

clintandrewhall · 2020-11-18T16:56:14Z

x-pack/plugins/lens/public/pie_visualization/expression.tsx

          chartsThemeService={dependencies.chartsThemeService}
          paletteService={dependencies.paletteService}
          onClickValue={onClickValue}
+          renderMode={handlers.getMode()}


Suggested change

renderMode={handlers.getMode()}

renderMode={handlers.getRenderMode()}

clintandrewhall · 2020-11-18T16:56:46Z

x-pack/plugins/lens/public/xy_visualization/expression.tsx

          histogramBarTarget={dependencies.histogramBarTarget}
          onClickValue={onClickValue}
          onSelectRange={onSelectRange}
+          renderMode={handlers.getMode()}


Suggested change

renderMode={handlers.getMode()}

renderMode={handlers.getRenderMode()}

flash1293 · 2020-11-20T08:52:05Z

Fair point @clintandrewhall , I changed it to "getRenderMode"

flash1293 · 2020-11-23T13:33:30Z

@elasticmachine merge upstream

kibanamachine · 2020-11-23T15:49:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: bba4b75

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1.3MB	1.3MB	+33.0B
`lens`	935.0KB	935.4KB	+435.0B
total			+468.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`canvas`	908.9KB	908.9KB	+29.0B
`expressions`	182.3KB	182.4KB	+132.0B
total			+161.0B

History

💔 Build #89573 failed 9d95c5e
💚 Build #89170 succeeded 89ed61e
💚 Build #88542 succeeded 069a29e
💔 Build #88539 failed 9826e0c
💚 Build #88521 succeeded cea4ec8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dej611

Tested in Chrome and Firefox

…tic#83559)

* master: (41 commits) [Maps] fix code-owners (elastic#84265) [@kbn/utils] Clean target before build (elastic#84253) [code coverage] collect for oss integration tests (elastic#83907) [APM] Use `asTransactionRate` consistently everywhere (elastic#84213) Attempt to fix incremental build error (elastic#84152) Unskip "Copy dashboards to space" (elastic#84115) Remove expressions.legacy from README (elastic#79681) Expression: Add render mode and use it for canvas interactivity (elastic#83559) [deb/rpm] Move systemd service to /usr/lib/systemd/system (elastic#83571) [Security Solution][Resolver] Allow a configurable entity_id field (elastic#81679) [ML] Space permision checks for job deletion (elastic#83871) [build] Provide ARM build of RE2 (elastic#84163) TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (elastic#83628) [Workplace Search] Initial rendering of Org Sources (elastic#84164) update geckodriver to 0.28 (elastic#84085) Fix timelion vis escapes single quotes (elastic#84196) [Security Solution] Fix incorrect time for dns histogram (elastic#83532) [DX] Bump TS version to v4.1 (elastic#83397) [Security Solution] Add endpoint policy revision number (elastic#83982) [Fleet] Integration Policies List view (elastic#83634) ...

…) (#84259)

add render mode and use it for canvas interactivity

778fc7b

flash1293 added Feature:Lens release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Nov 17, 2020

flash1293 added 3 commits November 18, 2020 11:25

Merge remote-tracking branch 'upstream/master' into lens/handler-mode

7eafa1d

fix bugs

cea4ec8

handle render mode in pie chart as well

9826e0c

flash1293 marked this pull request as ready for review November 18, 2020 13:01

flash1293 requested a review from a team November 18, 2020 13:01

flash1293 requested review from a team as code owners November 18, 2020 13:01

flash1293 added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Nov 18, 2020

flash1293 added Team:AppArch Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// labels Nov 18, 2020

pass through flag for pies

069a29e

botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Nov 18, 2020

ppisljar approved these changes Nov 18, 2020

View reviewed changes

clintandrewhall approved these changes Nov 18, 2020

View reviewed changes

flash1293 added 2 commits November 20, 2020 09:30

Merge remote-tracking branch 'upstream/master' into lens/handler-mode

285cb42

getMode -> getRenderMode

89ed61e

flash1293 added 3 commits November 20, 2020 10:15

Merge remote-tracking branch 'upstream/master' into lens/handler-mode

2df96d3

Merge remote-tracking branch 'upstream/master' into lens/handler-mode

9d95c5e

fix bug

fe0115b

Merge branch 'master' into lens/handler-mode

bba4b75

dej611 approved these changes Nov 24, 2020

View reviewed changes

flash1293 merged commit 38a09b9 into elastic:master Nov 24, 2020

flash1293 added a commit to flash1293/kibana that referenced this pull request Nov 24, 2020

Expression: Add render mode and use it for canvas interactivity (elas…

4c48826

…tic#83559)

flash1293 mentioned this pull request Nov 24, 2020

[7.x] Expression: Add render mode and use it for canvas interactivity (#83559) #84259

Merged

flash1293 added a commit that referenced this pull request Nov 25, 2020

Expression: Add render mode and use it for canvas interactivity (#83559…

79fa876

…) (#84259)

drewdaemon mentioned this pull request Oct 26, 2023

[Lens] create strategy for embeddable interaction customization #169983

Open

	renderMode={handlers.getMode()}
	renderMode={handlers.getRenderMode()}

Conversation

flash1293 commented Nov 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Nov 18, 2020

Uh oh!

elasticmachine commented Nov 18, 2020

Uh oh!

elasticmachine commented Nov 18, 2020

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

clintandrewhall left a comment

Choose a reason for hiding this comment

Uh oh!

clintandrewhall Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

clintandrewhall Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

clintandrewhall Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

clintandrewhall Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

clintandrewhall Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

clintandrewhall Nov 18, 2020

Choose a reason for hiding this comment

Uh oh!

flash1293 commented Nov 20, 2020

Uh oh!

flash1293 commented Nov 23, 2020

Uh oh!

kibanamachine commented Nov 23, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

dej611 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

flash1293 commented Nov 17, 2020 •

edited

Loading