Skip to content

[Metrics UI] Add Process tab to Enhanced Node Details#83477

Merged
Zacqary merged 12 commits intoelastic:masterfrom
Zacqary:80307-process-list
Nov 18, 2020
Merged

[Metrics UI] Add Process tab to Enhanced Node Details#83477
Zacqary merged 12 commits intoelastic:masterfrom
Zacqary:80307-process-list

Conversation

@Zacqary
Copy link
Copy Markdown
Contributor

@Zacqary Zacqary commented Nov 16, 2020 •
edited
Loading

Summary

Closes #80307

Screen Shot 2020-11-16 at 1 54 57 PM

Screen Shot 2020-11-16 at 1 55 56 PM

Screen Shot 2020-11-16 at 1 55 30 PM

Still Todo

  • This PR does not include a functional View trace in APM button, but it does have a placeholder for it in the code
  • The mini graphs in the CPU and Memory columns are not yet implemented
  • This UI is not fully responsive. A responsive design ticket would be helpful

Checklist

Delete any items that are not applicable to this PR.

@Zacqary Zacqary added release_note:enhancement Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 labels Nov 16, 2020
@Zacqary Zacqary requested a review from a team as a code owner November 16, 2020 20:07
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 16, 2020

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 16, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1039 1048 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.5MB 2.5MB +34.4KB

Distributable file count

id before after diff
default 42835 42840 +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

phillipb
phillipb approved these changes Nov 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary Zacqary merged commit 21c0258 into elastic:master Nov 18, 2020
@Zacqary Zacqary deleted the 80307-process-list branch November 18, 2020 16:41
@Zacqary Zacqary mentioned this pull request Nov 18, 2020
Merged
Zacqary added a commit to Zacqary/kibana that referenced this pull request Nov 18, 2020
@Zacqary
[Metrics UI] Add Process tab to Enhanced Node Details (elastic#83477)
aa3b663
Zacqary added a commit that referenced this pull request Nov 18, 2020
@Zacqary
[7.x] [Metrics UI] Add Process tab to Enhanced Node Details (#83477) (#…
dd3ea9c 
…83668)
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 18, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-metrics-t…
1a78578 
…o-node-details

* 'master' of github.com:elastic/kibana:
  [ML] Performance improvements to annotations editing in Single Metric Viewer & buttons placement (elastic#83216)
  [Metrics UI] Add Process tab to Enhanced Node Details (elastic#83477)
@kaiyan-sheng kaiyan-sheng mentioned this pull request Nov 25, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@phillipb phillipb phillipb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Metrics UI] Enhanced host details - Processes

4 participants

@Zacqary @elasticmachine @kibanamachine @phillipb