Remove dependency of tests on strict SyntaxKind values#83440
Merged
afharo merged 1 commit intoelastic:masterfrom Nov 16, 2020
Merged
Remove dependency of tests on strict SyntaxKind values#83440afharo merged 1 commit intoelastic:masterfrom
afharo merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
TinaHeiligers
approved these changes
Nov 16, 2020
Contributor
TinaHeiligers
left a comment
There was a problem hiding this comment.
The changes seem innocent enough. LGTM once the tests to green.
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
afharo
added a commit
that referenced
this pull request
Nov 16, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 19, 2020
…ode-details * 'master' of github.com:elastic/kibana: Remove dependency of tests on strict SyntaxKind values (elastic#83440) [SecuritySolution] override timerange for prebuilt templates (elastic#82468) [Enterprise Search] Added a shouldShowActiveForSubroutes option (elastic#83338) [Lens] Make the dimension flyout panel stay close on outside click (elastic#83059) [Security Solution] Gracefully handle errors in detection rules install (elastic#83306) Fix advanced settings category sorting (elastic#83394)
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests in
@kbn/telemetry-toolsrely on strictSyntaxKindvalues. So, for every update in the TS libraries, they might change, leading to the snapshots in the tests to need a refresh.This PR changes the assertion so it no longer relies on strict values and updates as TS updates them.
Related to #83397
Checklist
Delete any items that are not applicable to this PR.
For maintainers