Skip to content

[Fleet] Rename usage collection object to 'fleet'.#83407

Merged
skh merged 4 commits intoelastic:masterfrom
skh:rename-telemetry-object
Nov 24, 2020
Merged

[Fleet] Rename usage collection object to 'fleet'.#83407
skh merged 4 commits intoelastic:masterfrom
skh:rename-telemetry-object

Conversation

@skh
Copy link
Copy Markdown
Contributor

@skh skh commented Nov 16, 2020 •
edited
Loading

Summary

Fixes #80118.

This changes the telemetry object to follow the recent renamings in the fleet plugin.

@skh skh added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 labels Nov 16, 2020
@skh skh self-assigned this Nov 16, 2020
@skh skh added the Feature:Fleet Fleet team's agent central management project label Nov 16, 2020
@ph
Copy link
Copy Markdown
Contributor

ph commented Nov 16, 2020

@mostlyjason FYI this will impact your dashboard.

@nchaulet
Copy link
Copy Markdown
Member

nchaulet commented Nov 16, 2020

@skh should we also rename fleet_enabled in the schema agents_enabled?

@mostlyjason
Copy link
Copy Markdown
Contributor

mostlyjason commented Nov 16, 2020

What is fleet_enabled measuring? Is it measuring if they enabled central management? If so, it could be central_mgmt_enabled?

@skh skh force-pushed the rename-telemetry-object branch from 0ca5fd1 to 009d01f Compare November 18, 2020 09:17
@skh skh changed the title Rename usage collection object to 'fleet'. [Fleet] Rename usage collection object to 'fleet'. Nov 18, 2020
@skh
Copy link
Copy Markdown
Contributor Author

skh commented Nov 18, 2020 •
edited
Loading

What is fleet_enabled measuring? Is it measuring if they enabled central management? If so, it could be central_mgmt_enabled?

It reports the setting xpack.fleet.agents.enabled, which used to be xpack.ingestManager.fleet.enabled. We can name it whatever we want in the telemetry object.

@skh skh force-pushed the rename-telemetry-object branch from 009d01f to f053cbe Compare November 23, 2020 08:48
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 23, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@skh skh marked this pull request as ready for review November 23, 2020 12:58
@skh skh requested a review from a team November 23, 2020 12:58
@skh skh requested a review from a team as a code owner November 23, 2020 12:58
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 23, 2020

Pinging @elastic/ingest-management (Feature:Fleet)

@mostlyjason
Copy link
Copy Markdown
Contributor

mostlyjason commented Nov 23, 2020

@cosiomoises @bradenlpreston @caitlinbetz @sorantis if you use fleet telemetry, this rename may affect your dashboards

nchaulet
nchaulet approved these changes Nov 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skh skh merged commit aa07f5c into elastic:master Nov 24, 2020
@skh skh deleted the rename-telemetry-object branch November 24, 2020 09:12
@skh skh mentioned this pull request Nov 24, 2020
Merged
skh added a commit that referenced this pull request Nov 24, 2020
@skh
[Fleet] Rename usage collection object to 'fleet'. (#83407) (#84182)
f942ede 
* Rename usage collection object to 'fleet'.

* Update telemetry mapping.

* Adjust naming.

* Rename ingestManager -> fleet in telemetry collector
@afharo afharo mentioned this pull request Nov 25, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nchaulet nchaulet nchaulet approved these changes

@Bamieh Bamieh Bamieh approved these changes

Assignees

@skh skh

Labels

Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ingest_manager key is not renamed to fleet in Telemetry collection data

7 participants

@skh @ph @nchaulet @mostlyjason @kibanamachine @elasticmachine @Bamieh