[Maps] Type aggregations#83294
Merged
thomasneirynck merged 16 commits intoelastic:masterfrom Nov 16, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
reviewed
Nov 12, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
Can you move all agg_field files into a folder under fields and expose key parts with index file to avoid cluttering field folder?
x-pack/plugins/maps/public/components/metrics_editor/metric_editor.tsx
Outdated
Show resolved
Hide resolved
8 tasks
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Nov 16, 2020
Splits the AggDescriptor into multiple types, to better distinguish Counts from aggs with fields. Corresponding split in agg-classes.
thomasneirynck
added a commit
that referenced
this pull request
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes typing for aggregations more fine-grained, by splitting off the fielded-agg.
This PR introduces a new typing that serves as a prereq for adding the percentile aggregation. Percentile will require additional params that are not relevant for the other aggs.