[Canvas] Disable exporting/importing of templates. Optimize pitch images a bit#83098
Merged
crob611 merged 2 commits intoelastic:masterfrom Nov 19, 2020
Merged
[Canvas] Disable exporting/importing of templates. Optimize pitch images a bit#83098crob611 merged 2 commits intoelastic:masterfrom
crob611 merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
Author
|
@ryankeairns or @MichaelMarcialis you all will probably want to take a look at the resulting pitch template to make sure the optimized images still look ok. Make sure you start up a fresh Elasticsearch instance to make sure you get the newest version of the template, |
ryankeairns
approved these changes
Nov 11, 2020
clintandrewhall
approved these changes
Nov 13, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Nov 19, 2020
…elastic#83098) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Nov 19, 2020
…elastic#83098) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 19, 2020
* master: skip "Dashboards linked by a drilldown are both copied to a space" (elastic#83824) [alerts] adds action group and date to mustache template variables for actions (elastic#83195) skip flaky suite (elastic#79389) [DOCS] Reallocates limitations to point-of-use (elastic#79582) [Enterprise Search] Engine overview layout stub (elastic#83756) Disable exporting/importing of templates. Optimize pitch images a bit (elastic#83098) [DOCS] Consolidates plugins (elastic#83712) [ML] Space management UI (elastic#83320) test just part of the message to avoid updates (elastic#83703) [Data Table] Remove extra column in split mode (elastic#83193) Improve snapshot error messages (elastic#83785) skip flaky suite (elastic#83773) skip flaky suite (elastic#83771) skip flaky suite (elastic#65278) skip flaky suite (elastic#83793) [Task Manager] Ensures retries are inferred from the schedule of recurring tasks (elastic#83682) [index patterns] improve index pattern cache (elastic#83368) [Fleet] Rename ingestManager plugin ID fleet (elastic#83200) fixed pagination in connectors list (elastic#83638)
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 19, 2020
…elastic#83098) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #81560
This disallows the exporting and importing of Canvas Workpad Template saved objects from Saved Object Management. We don't really have a reason for allowing these exports now, and if we decide there is a reason in the future we can readdress, but with installation from Fleet coming relatively soon, I'm not sure we will have a reason for that.
I also ran all of the images in the pitch_presentation template through some optimizers to reduce quality a bit, and it has significantly reduced the size of that template.