[Fleet] Move ingestManager plugin to fleet#82886
Merged
nchaulet merged 12 commits intoelastic:masterfrom Nov 9, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
cjcenizal
suggested changes
Nov 7, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Thanks for the ping! Caught a few typos likely caused by bulk find/replace.
x-pack/plugins/index_management/public/application/app_context.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/index_management/public/application/mount_management_section.ts
Outdated
Show resolved
Hide resolved
cjcenizal
approved these changes
Nov 7, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Index management code LGTM
jfsiii
reviewed
Nov 9, 2020
Contributor
jfsiii
left a comment
There was a problem hiding this comment.
LGTM after reading. Will pull down & run, too.
Contributor
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
jfsiii
approved these changes
Nov 9, 2020
Contributor
jfsiii
left a comment
There was a problem hiding this comment.
Checked out locally and did a happy path check for a few things. LGTM 🚀
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Nov 9, 2020
# Conflicts: # .github/CODEOWNERS # .github/paths-labeller.yml # x-pack/plugins/fleet/server/services/epm/archive/cache.ts # x-pack/plugins/fleet/server/services/epm/registry/cache.ts # x-pack/plugins/ingest_manager/server/services/epm/archive/cache.ts
nchaulet
added a commit
that referenced
this pull request
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the effort of renaming the
ingestManagerpluginfleet, move the plugin fromingestManagertofleetRenaming the plugin ID will come in a following pull request ( this will rename the kibana URL => ingestManager => fleet)
Detailed renaming