[Visualizations] Remove kui usage#82810
Merged
stratoula merged 5 commits intoelastic:masterfrom Nov 10, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Left two comments for your review. Thanks!
src/plugins/visualizations/public/embeddable/disabled_lab_visualization.tsx
Outdated
Show resolved
Hide resolved
src/plugins/visualizations/public/embeddable/disabled_lab_visualization.scss
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
MichaelMarcialis
approved these changes
Nov 9, 2020
Contributor
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Thanks for addressing those earlier comments. This looks great. I left two super small nitpick comments for your review, but otherwise, this LGTM. Approving now so I don't hold you up any further.
src/plugins/visualizations/public/embeddable/disabled_lab_visualization.tsx
Outdated
Show resolved
Hide resolved
| className="kuiVerticalRhythm visDisabledLabVisualization__icon kuiIcon fa-flask" | ||
| aria-hidden="true" | ||
| <I18nProvider> | ||
| <EuiEmptyPrompt |
Contributor
There was a problem hiding this comment.
Nit: can we add a titleSize="xs" prop to EuiEmptyPrompt?
Contributor
Author
There was a problem hiding this comment.
I addressed them both! Thank you 🙂
Contributor
💚 Build SucceededMetrics [docs]async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Nov 9, 2020
Contributor
|
Checked both for dashboard and the visualization itself - both work great. Nice improvement!!! |
mbondyra
approved these changes
Nov 10, 2020
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Nov 10, 2020
* [Visualize] Remove kui usage * Use EuiPromptButton istead of EuiCallout * Add a link to advanced settings for visualizations docs * Changes requested on code review Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Nov 10, 2020
* [Visualize] Remove kui usage * Use EuiPromptButton istead of EuiCallout * Add a link to advanced settings for visualizations docs * Changes requested on code review Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 10, 2020
…kibana into bootstrap-node-details-overlay * 'bootstrap-node-details-overlay' of github.com:phillipb/kibana: (49 commits) [Security Solution] Fix DNS Network table query (elastic#82778) [Workplace Search] Consolidate groups routes (elastic#83015) Adds cloud links to user menu (elastic#82803) [Security Solution][Detections] - follow up cleanup on auto refresh rules (elastic#83023) [App Search] Added the log retention panel to the Settings page (elastic#82982) [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (elastic#83006) [DOCS] Consolidates drilldown pages (elastic#82081) [Maps] add on-prem EMS config (elastic#82525) migrate i18n mixin to KP (elastic#81799) [bundle optimization] fix imports of react-use lib (elastic#82847) [Discover] Add metric on adding filter (elastic#82961) [Lens] Performance refactoring for indexpattern fast lookup and Operation support matrix computation (elastic#82829) skip flaky suite (elastic#82804) Fix SO query for searching across spaces (elastic#83025) renaming built-in alerts to Stack Alerts (elastic#82873) [TSVB] Disable using top_hits in pipeline aggregations (elastic#82278) [Visualizations] Remove kui usage (elastic#82810) [Visualizations] Make the icon buttons labels more descriptive (elastic#82585) [Lens] Do not reset formatting when switching between custom ranges and auto histogram (elastic#82694) Fix ilm navigation (elastic#81664) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 10, 2020
…na into alerts/stack-alerts-public * 'alerts/stack-alerts-public' of github.com:gmmorris/kibana: [Security Solution] Fix DNS Network table query (elastic#82778) [Workplace Search] Consolidate groups routes (elastic#83015) Adds cloud links to user menu (elastic#82803) [Security Solution][Detections] - follow up cleanup on auto refresh rules (elastic#83023) [App Search] Added the log retention panel to the Settings page (elastic#82982) [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (elastic#83006) [DOCS] Consolidates drilldown pages (elastic#82081) [Maps] add on-prem EMS config (elastic#82525) migrate i18n mixin to KP (elastic#81799) [bundle optimization] fix imports of react-use lib (elastic#82847) [Discover] Add metric on adding filter (elastic#82961) [Lens] Performance refactoring for indexpattern fast lookup and Operation support matrix computation (elastic#82829) skip flaky suite (elastic#82804) Fix SO query for searching across spaces (elastic#83025) renaming built-in alerts to Stack Alerts (elastic#82873) [TSVB] Disable using top_hits in pipeline aggregations (elastic#82278) [Visualizations] Remove kui usage (elastic#82810) [Visualizations] Make the icon buttons labels more descriptive (elastic#82585) [Lens] Do not reset formatting when switching between custom ranges and auto histogram (elastic#82694) :
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #82711. I removed the kui usage from https://github.com/elastic/kibana/blob/master/src/plugins/visualizations/public/embeddable/disabled_lab_visualization.tsx. I actually replaced the previous message with a
EuiCalloutEuiEmptyPrompt.Before:
Now:
Checklist
Delete any items that are not applicable to this PR.